Unable to build iptables on linux kernel 2.6.10 + 2.6.11-rc2 + 2.6.11-rc2-bk5

Unable to build iptables on linux kernel 2.6.10 + 2.6.11-rc2 + 2.6.11-rc2-bk5

[Colin Harrison]

Hi
I am experimenting with the linux kernel 2.6.10 + 2.6.11-rc2 +
2.6.11-rc2-bk5.
When I try to build CVS snapshot iptables (iptables-1.3.0-20050125) against
this kernel I get:-


make KERNEL_DIR=/home/src/kernel/linux-2.6.10
....
cc -O2 -Wall -Wunused -I/home/src/kernel/linux-2.6.10/include -Iinclude/
-DIPTABLES_VERSION=\"1.3.0-20050125\"  -fPIC -o
extensions/libipt_conntrack_sh.o -c extensions/libipt_conntrack.c
In file included from extensions/libipt_conntrack.c:13:
/home/src/kernel/linux-2.6.10/include/linux/netfilter_ipv4/ip_conntrack_tupl
e.h:67: error: parse error before "u8"
/home/src/kernel/linux-2.6.10/include/linux/netfilter_ipv4/ip_conntrack_tupl
e.h:67: warning: no semicolon at end of struct or union
/home/src/kernel/linux-2.6.10/include/linux/netfilter_ipv4/ip_conntrack_tupl
e.h:67: warning: no semicolon at end of struct or union
/home/src/kernel/linux-2.6.10/include/linux/netfilter_ipv4/ip_conntrack_tupl
e.h:70: warning: type defaults to `int' in declaration of `dir'
...

The kernel appears to be patched with all the latest conntrack changes and
compiles cleanly.

More info. can be supplied, as required.

Thanks

Colin Harrison

Re: Unable to build iptables on linux kernel 2.6.10 + 2.6.11-rc2 + 2.6.11-rc2-bk5

[Pablo Neira]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

Colin Harrison wrote:

>Hi
>I am experimenting with the linux kernel 2.6.10 + 2.6.11-rc2 +
>2.6.11-rc2-bk5.
>When I try to build CVS snapshot iptables (iptables-1.3.0-20050125) against
>this kernel I get:-
>
>
>make KERNEL_DIR=/home/src/kernel/linux-2.6.10
>....
>cc -O2 -Wall -Wunused -I/home/src/kernel/linux-2.6.10/include -Iinclude/
>-DIPTABLES_VERSION=\"1.3.0-20050125\"  -fPIC -o
>extensions/libipt_conntrack_sh.o -c extensions/libipt_conntrack.c
>In file included from extensions/libipt_conntrack.c:13:
>/home/src/kernel/linux-2.6.10/include/linux/netfilter_ipv4/ip_conntrack_tupl
>e.h:67: error: parse error before "u8"
>  
>
u8 seems not to be defined in user space, that's why iptables complains 
in compilation time. A quick grep at /usr/include on my laptop tells me 
that such definition doesn't exist in user space. AFAICS it's only 
defined in kernel space. So, I've renamed it to u_int8_t and that fixed 
the problem.

Patrick, if this is the best way to fix this problem, are you willing to 
add it to your patchset?

Signed-off-by: Pablo Neira Ayuso <pablo@eurodev.net>

--
Pablo

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 424 bytes --]

===== include/linux/netfilter_ipv4/ip_conntrack_tuple.h 1.6 vs edited =====
--- 1.6/include/linux/netfilter_ipv4/ip_conntrack_tuple.h	2005-01-17 23:02:05 +01:00
+++ edited/include/linux/netfilter_ipv4/ip_conntrack_tuple.h	2005-01-30 23:19:09 +01:00
@@ -64,10 +64,10 @@
 		} u;
 
 		/* The protocol. */
-		u8 protonum;
+		u_int8_t protonum;
 
 		/* The direction (for tuplehash) */
-		u8 dir;
+		u_int8_t dir;
 	} dst;
 };
 

Re: Unable to build iptables on linux kernel 2.6.10 + 2.6.11-rc2 + 2.6.11-rc2-bk5

[Thomas Graf]

>  		/* The protocol. */
> -		u8 protonum;
> +		u_int8_t protonum;
>  
>  		/* The direction (for tuplehash) */
> -		u8 dir;
> +		u_int8_t dir;

I think __u8 would be a better choice.

Re: Unable to build iptables on linux kernel 2.6.10 + 2.6.11-rc2 + 2.6.11-rc2-bk5

[Pablo Neira]

Thomas Graf wrote:

>> 		/* The protocol. */
>>-		u8 protonum;
>>+		u_int8_t protonum;
>> 
>> 		/* The direction (for tuplehash) */
>>-		u8 dir;
>>+		u_int8_t dir;
>>    
>>
>
>I think __u8 would be a better choice.
>  
>

I don't think so. With __u8 iptables doesn't compile anymore on my laptop.

cc -O2 -Wall -Wunused -I/home/pablo/bk/linux-2.5/include -Iinclude/ 
-DIPTABLES_VERSION=\"1.3.0\"  -fPIC -o extensions/libipt_conntrack_sh.o 
-c extensions/libipt_conntrack.c
In file included from extensions/libipt_conntrack.c:13:
/home/pablo/bk/linux-2.5/include/linux/netfilter_ipv4/ip_conntrack_tuple.h:67: 
parse error before `__u8'
/home/pablo/bk/linux-2.5/include/linux/netfilter_ipv4/ip_conntrack_tuple.h:67: 
warning: no semicolon at end of struct or union
...

--
Pablo

Re: Unable to build iptables on linux kernel 2.6.10 + 2.6.11-rc2 + 2.6.11-rc2-bk5

[Tomáš Macek]

Whats the exact difference between each of the possibilities?


On Tue, 1 Feb 2005, Thomas Graf wrote:

>>  		/* The protocol. */
>> -		u8 protonum;
>> +		u_int8_t protonum;
>>
>>  		/* The direction (for tuplehash) */
>> -		u8 dir;
>> +		u_int8_t dir;
>
> I think __u8 would be a better choice.
>
>
>
>
>
>
>

Re: Unable to build iptables on linux kernel 2.6.10 + 2.6.11-rc2 + 2.6.11-rc2-bk5

[Patrick McHardy]

Thomas Graf wrote:

>> 		/* The protocol. */
>>-		u8 protonum;
>>+		u_int8_t protonum;
>> 
>> 		/* The direction (for tuplehash) */
>>-		u8 dir;
>>+		u_int8_t dir;
>>
>
>I think __u8 would be a better choice.
>
Usually yes, but all netfilter headers use u_intX_t.

Re: Unable to build iptables on linux kernel 2.6.10 + 2.6.11-rc2 + 2.6.11-rc2-bk5

[Patrick McHardy]

Pablo Neira wrote:

> u8 seems not to be defined in user space, that's why iptables 
> complains in compilation time. A quick grep at /usr/include on my 
> laptop tells me that such definition doesn't exist in user space. 
> AFAICS it's only defined in kernel space. So, I've renamed it to 
> u_int8_t and that fixed the problem.
>
> Patrick, if this is the best way to fix this problem, are you willing 
> to add it to your patchset?

It's the easiest way :)

Applied, thanks.