Re: [PATCH v11 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
	bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
	manivannan.sadhasivam@linaro.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
	kishon@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
	p.zabel@pengutronix.de, quic_nsekar@quicinc.com,
	dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v11 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574
Date: Thu, 6 Mar 2025 12:52:48 +0100	[thread overview]
Message-ID: <41b400fe-5e08-42c0-9bc6-a238d25d155a@kernel.org> (raw)
In-Reply-To: <20250220094251.230936-4-quic_varada@quicinc.com>

On 20/02/2025 10:42, Varadarajan Narayanan wrote:
> All DT entries except "reg" is similar between ipq5332 and ipq9574. ipq9574
> has 5 registers while ipq5332 has 6. MHI is the additional (i.e. sixth
> entry). Since this matches with the sdx55's "reg" definition which allows
> for 5 or 6 registers, combine ipq9574 with sdx55.
> 
> This change is to prepare ipq9574 to be used as ipq5332's fallback
> compatible.
> 
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Unreviewed.

> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v8: Add 'Reviewed-by: Krzysztof Kozlowski'
> ---
>  Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 7235d6554cfb..4b4927178abc 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -169,7 +169,6 @@ allOf:
>              enum:
>                - qcom,pcie-ipq6018
>                - qcom,pcie-ipq8074-gen3
> -              - qcom,pcie-ipq9574

Why you did not explain that you are going to affect users of DTS?

NAK

Best regards,
Krzysztof