[PATCH] ASoC: Intel: Skylake: Update description for HDaudio kconfig

[PATCH] ASoC: Intel: Skylake: Update description for HDaudio kconfig

[Cezary Rojewski]

With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied,
warning is no longer true. Remove it and update the description.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/soc/intel/Kconfig | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index c8de0bb5bed9..4d11f4f3f7e2 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK
 config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
 	bool "HDAudio codec support"
 	help
-	  This option broke audio on Linus' Skylake laptop in December 2018
-	  and the race conditions during the probe were not fixed since.
-	  This option is DEPRECATED, all HDaudio codec support needs
-	  to be handled by the SOF driver.
-	  Distributions should not enable this option and there are no known
-	  users of this capability.
+	  If you have Intel Skylake or Kabylake with HDaudio codec
+	  then enable this option by saying Y or m.
 
 config SND_SOC_INTEL_SKYLAKE_COMMON
 	tristate
-- 
2.17.1

Re: [PATCH] ASoC: Intel: Skylake: Update description for HDaudio kconfig

[Pierre-Louis Bossart]

On 5/6/20 3:52 PM, Cezary Rojewski wrote:
> With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied,
> warning is no longer true. Remove it and update the description.
> 
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
>   sound/soc/intel/Kconfig | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index c8de0bb5bed9..4d11f4f3f7e2 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK
>   config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
>   	bool "HDAudio codec support"
>   	help
> -	  This option broke audio on Linus' Skylake laptop in December 2018
> -	  and the race conditions during the probe were not fixed since.
> -	  This option is DEPRECATED, all HDaudio codec support needs
> -	  to be handled by the SOF driver.
> -	  Distributions should not enable this option and there are no known
> -	  users of this capability.
> +	  If you have Intel Skylake or Kabylake with HDaudio codec

I would have added HDaudio codec + dmic but that's good enough, the 
selection based on DMIC presence will be done by your other patch so

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thanks Cezary.


> +	  then enable this option by saying Y or m.
>   
>   config SND_SOC_INTEL_SKYLAKE_COMMON
>   	tristate
> 

Re: [PATCH] ASoC: Intel: Skylake: Update description for HDaudio kconfig

[Cezary Rojewski]

On 2020-05-06 22:57, Pierre-Louis Bossart wrote:
> 
> 
> On 5/6/20 3:52 PM, Cezary Rojewski wrote:
>> With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied,
>> warning is no longer true. Remove it and update the description.
>>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>> ---
>>   sound/soc/intel/Kconfig | 8 ++------
>>   1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
>> index c8de0bb5bed9..4d11f4f3f7e2 100644
>> --- a/sound/soc/intel/Kconfig
>> +++ b/sound/soc/intel/Kconfig
>> @@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK
>>   config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
>>       bool "HDAudio codec support"
>>       help
>> -      This option broke audio on Linus' Skylake laptop in December 2018
>> -      and the race conditions during the probe were not fixed since.
>> -      This option is DEPRECATED, all HDaudio codec support needs
>> -      to be handled by the SOF driver.
>> -      Distributions should not enable this option and there are no known
>> -      users of this capability.
>> +      If you have Intel Skylake or Kabylake with HDaudio codec
> 
> I would have added HDaudio codec + dmic but that's good enough, the 
> selection based on DMIC presence will be done by your other patch so
> 
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> Thanks Cezary.
> 
> 
>> +      then enable this option by saying Y or m.
>>   config SND_SOC_INTEL_SKYLAKE_COMMON
>>       tristate
>>

Do you want me to spin v3? While copying desc from other kconfgs, I 
added 'or m' by mistake. Don't mind to update once more if you want me to.

Czarek

Re: [PATCH] ASoC: Intel: Skylake: Update description for HDaudio kconfig

[Pierre-Louis Bossart]

>>> +      If you have Intel Skylake or Kabylake with HDaudio codec
>>
>> I would have added HDaudio codec + dmic but that's good enough, the 
>> selection based on DMIC presence will be done by your other patch so
>>
>> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>
>> Thanks Cezary.
>>
>>
>>> +      then enable this option by saying Y or m.
>>>   config SND_SOC_INTEL_SKYLAKE_COMMON
>>>       tristate
>>>
> 
> Do you want me to spin v3? While copying desc from other kconfgs, I 
> added 'or m' by mistake. Don't mind to update once more if you want me to.

That would be nicer indeed if you don't mind, thanks!