From: Paulo Marques <pmarques@grupopie.com>
To: Pekka Enberg <penberg@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
penberg@cs.helsinki.fi
Subject: [uml-devel] Re: [PATCH 2.6] 4/7 replace uml_strdup by kstrdup
Date: Wed, 02 Feb 2005 11:55:13 +0000 [thread overview]
Message-ID: <4200BFA1.2060808@grupopie.com> (raw)
In-Reply-To: <84144f02050201235257d0ec1c@mail.gmail.com>
Pekka Enberg wrote:
> On Tue, 1 Feb 2005 03:28:31 +0000, pmarques@grupopie.com
> <pmarques@grupopie.com> wrote:
>
>>diff -buprN -X dontdiff vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c linux-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c
>>--- vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c 2004-12-24 21:35:40.000000000 +0000
>>+++ linux-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c 2005-01-31 20:39:08.591154025 +0000
>
>
> [snip]
>
>
>>- pri->dev_name = uml_strdup(buffer);
>>+ pri->dev_name = kstrdup(buffer);
>
>
> Please compile-test before submitting.
I'm really sorry about this...
I've compiled with an allyesconfig to validate the changes, but that
doesn't build the UML parts :(
Anyway, thanks for pointing this out. I still haven't got feedback
regarding the acceptance of these patches. If there is a chance they're
accepted, maybe the best thing to do is to post the series again with
this correction and the sound patch corrections.
--
Paulo Marques - www.grupopie.com
All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Paulo Marques <pmarques@grupopie.com>
To: Pekka Enberg <penberg@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
penberg@cs.helsinki.fi
Subject: Re: [PATCH 2.6] 4/7 replace uml_strdup by kstrdup
Date: Wed, 02 Feb 2005 11:55:13 +0000 [thread overview]
Message-ID: <4200BFA1.2060808@grupopie.com> (raw)
In-Reply-To: <84144f02050201235257d0ec1c@mail.gmail.com>
Pekka Enberg wrote:
> On Tue, 1 Feb 2005 03:28:31 +0000, pmarques@grupopie.com
> <pmarques@grupopie.com> wrote:
>
>>diff -buprN -X dontdiff vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c linux-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c
>>--- vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c 2004-12-24 21:35:40.000000000 +0000
>>+++ linux-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c 2005-01-31 20:39:08.591154025 +0000
>
>
> [snip]
>
>
>>- pri->dev_name = uml_strdup(buffer);
>>+ pri->dev_name = kstrdup(buffer);
>
>
> Please compile-test before submitting.
I'm really sorry about this...
I've compiled with an allyesconfig to validate the changes, but that
doesn't build the UML parts :(
Anyway, thanks for pointing this out. I still haven't got feedback
regarding the acceptance of these patches. If there is a chance they're
accepted, maybe the best thing to do is to post the series again with
this correction and the sound patch corrections.
--
Paulo Marques - www.grupopie.com
All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)
next prev parent reply other threads:[~2005-02-02 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-01 3:28 [uml-devel] [PATCH 2.6] 4/7 replace uml_strdup by kstrdup pmarques
2005-02-01 3:28 ` pmarques
2005-02-02 7:52 ` [uml-devel] " Pekka Enberg
2005-02-02 7:52 ` Pekka Enberg
2005-02-02 11:55 ` Paulo Marques [this message]
2005-02-02 11:55 ` Paulo Marques
2005-02-03 19:51 ` [uml-devel] " Blaisorblade
2005-02-03 19:51 ` Blaisorblade
2005-02-04 12:45 ` Paulo Marques
2005-02-04 12:45 ` Paulo Marques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4200BFA1.2060808@grupopie.com \
--to=pmarques@grupopie.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@gmail.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.