Titan ethernet and little endian

Titan ethernet and little endian

[Rojhalat Ibrahim]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

Hi,
a while ago I posted the attached patch,
which makes the titan_ge driver work in
little-endian mode. I got no reaction
whatsoever. What did I do wrong?
Rojhalat Ibrahim


[-- Attachment #2: titan_ge_little_endian_patch --]
[-- Type: text/plain, Size: 692 bytes --]

Index: titan_ge.h
===================================================================
RCS file: /home/cvs/linux/drivers/net/titan_ge.h,v
retrieving revision 1.17
diff -u -r1.17 titan_ge.h
--- titan_ge.h	4 Dec 2004 23:42:53 -0000	1.17
+++ titan_ge.h	10 Jan 2005 12:59:20 -0000
@@ -153,8 +153,10 @@
 
 /* Define the Rx descriptor */
 typedef struct eth_rx_desc {
-	u32	buffer_addr;	/* Buffer address inclusive of checksum */
-	u32     cmd_sts;	/* Command and Status info */
+	u32     buffer_addr;	/* CPU buffer address 	*/
+	u32     reserved;	/* Unused 		*/
+	u32	buffer;		/* XDMA buffer address	*/
+	u32	cmd_sts;	/* Command and Status	*/
 } titan_ge_rx_desc;
 
 /* Define the Tx descriptor */

Re: Titan ethernet and little endian

[Manish Lachwani]

Rojhalat Ibrahim wrote:

> Hi,
> a while ago I posted the attached patch,
> which makes the titan_ge driver work in
> little-endian mode. I got no reaction
> whatsoever. What did I do wrong?
> Rojhalat Ibrahim
>
>------------------------------------------------------------------------
>
>Index: titan_ge.h
>===================================================================
>RCS file: /home/cvs/linux/drivers/net/titan_ge.h,v
>retrieving revision 1.17
>diff -u -r1.17 titan_ge.h
>--- titan_ge.h	4 Dec 2004 23:42:53 -0000	1.17
>+++ titan_ge.h	10 Jan 2005 12:59:20 -0000
>@@ -153,8 +153,10 @@
> 
> /* Define the Rx descriptor */
> typedef struct eth_rx_desc {
>-	u32	buffer_addr;	/* Buffer address inclusive of checksum */
>-	u32     cmd_sts;	/* Command and Status info */
>+	u32     buffer_addr;	/* CPU buffer address 	*/
>+	u32     reserved;	/* Unused 		*/
>+	u32	buffer;		/* XDMA buffer address	*/
>+	u32	cmd_sts;	/* Command and Status	*/
> } titan_ge_rx_desc;
> 
> /* Define the Tx descriptor */
>  
>
Hi !

So, have you got the titan to work in the LE mode? Are you using the 
Yosemite board? Does this patch break BE?

Please do let us know.

Thanks
Manish Lachwani

Re: Titan ethernet and little endian

[Rojhalat Ibrahim]

Manish Lachwani wrote:
> Hi !
> 
> So, have you got the titan to work in the LE mode? Are you using the 
> Yosemite board? Does this patch break BE?
> 
> Please do let us know.
> 
> Thanks
> Manish Lachwani
> 
> 

Hi!

Yes I have got the titan work in LE mode. And yes I am using the
Yosemite board. And no this patch does not break BE. I haven't
actually tested that but all the changes I made are between
#ifdef LITTLE_ENDIAN and #endif.

Thanks
Rojhalat Ibrahim

Re: Titan ethernet and little endian

[Manish Lachwani]

Rojhalat Ibrahim wrote:

> Manish Lachwani wrote:
>
>> Hi !
>>
>> So, have you got the titan to work in the LE mode? Are you using the 
>> Yosemite board? Does this patch break BE?
>>
>> Please do let us know.
>>
>> Thanks
>> Manish Lachwani
>>
>>
>
> Hi!
>
> Yes I have got the titan work in LE mode. And yes I am using the
> Yosemite board. And no this patch does not break BE. I haven't
> actually tested that but all the changes I made are between
> #ifdef LITTLE_ENDIAN and #endif.
>
> Thanks
> Rojhalat Ibrahim
>
>
Ok, as long as the changes are in #ifdef. Although, your patch did not 
indicate the "#ifdef LITTLE_ENDIAN"

Thanks
Manish Lachwani

Re: Titan ethernet and little endian

[Rojhalat Ibrahim]

Manish Lachwani wrote:
> Rojhalat Ibrahim wrote:
> 
>> Manish Lachwani wrote:
>>
>>> Hi !
>>>
>>> So, have you got the titan to work in the LE mode? Are you using the 
>>> Yosemite board? Does this patch break BE?
>>>
>>> Please do let us know.
>>>
>>> Thanks
>>> Manish Lachwani
>>>
>>>
>>
>> Hi!
>>
>> Yes I have got the titan work in LE mode. And yes I am using the
>> Yosemite board. And no this patch does not break BE. I haven't
>> actually tested that but all the changes I made are between
>> #ifdef LITTLE_ENDIAN and #endif.
>>
>> Thanks
>> Rojhalat Ibrahim
>>
>>
> Ok, as long as the changes are in #ifdef. Although, your patch did not 
> indicate the "#ifdef LITTLE_ENDIAN"
> 
> Thanks
> Manish Lachwani
> 
> 
> 

That's because the #ifdef was already there. The code inbetween
was just not entirely correct.

Thanks
Rojhalat Ibrahim

Re: Titan ethernet and little endian

[Rojhalat Ibrahim]

Manish Lachwani wrote:
> Rojhalat Ibrahim wrote:
> 
>> Manish Lachwani wrote:
>>
>>> Hi !
>>>
>>> So, have you got the titan to work in the LE mode? Are you using the 
>>> Yosemite board? Does this patch break BE?
>>>
>>> Please do let us know.
>>>
>>> Thanks
>>> Manish Lachwani
>>>
>>>
>>
>> Hi!
>>
>> Yes I have got the titan work in LE mode. And yes I am using the
>> Yosemite board. And no this patch does not break BE. I haven't
>> actually tested that but all the changes I made are between
>> #ifdef LITTLE_ENDIAN and #endif.
>>
>> Thanks
>> Rojhalat Ibrahim
>>
>>
> Ok, as long as the changes are in #ifdef. Although, your patch did not 
> indicate the "#ifdef LITTLE_ENDIAN"
> 
> Thanks
> Manish Lachwani
> 
> 
> 

I have actually tested it also in BE mode now.
Is there any remaining reason not to apply this patch?

Thanks
Rojhalat Ibrahim