From: Patrick McHardy <kaber@trash.net>
To: Michael StJohns <mstjohns@mindspring.com>
Cc: Harald Welte <laforge@netfilter.org>,
netfilter-devel@lists.netfilter.org
Subject: Re: ip_queue.c inefficiencies?
Date: Fri, 04 Feb 2005 06:02:36 +0100 [thread overview]
Message-ID: <420301EC.7050002@trash.net> (raw)
In-Reply-To: <6.2.0.14.2.20050203160902.02ead150@pop.mindspring.com>
Michael StJohns wrote:
> At 01:39 PM 2/3/2005, Patrick McHardy wrote:
>
>> We hold queue_lock in your new check for queue_total >= queue_maxlen,
>> so the similar check in __ipq_enqueue_entry will never be true.
>> Therefore I removed it.
>
>
> Makes sense. I had left it in because I wasn't sure if anyone else
> was calling it (__ipq_enqueue_entry). Given the changes, it might
> actually make sense to eliminate __ipq_enqueue_entry by moving the
> last two lines of code into ipq_enqueue_entry
>
Yes, I just left it in as counterpart to __ipq_dequeue_entry,
although it would make the code clearer to remove both. Both
functions are inlined, so it doesn't really matter.
Regards
Patrick
next prev parent reply other threads:[~2005-02-04 5:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 0:18 ip_queue.c inefficiencies? Michael StJohns
2005-02-01 13:11 ` Harald Welte
2005-02-02 15:18 ` Patrick McHardy
[not found] ` <6.2.0.14.2.20050202105005.05278940@pop.mindspring.com>
2005-02-03 18:39 ` Patrick McHardy
2005-02-03 21:15 ` Michael StJohns
2005-02-04 5:02 ` Patrick McHardy [this message]
2005-02-04 23:01 ` Michael StJohns
2005-02-05 16:43 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420301EC.7050002@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=mstjohns@mindspring.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.