From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: netfilter-devel@lists.netfilter.org,
Michael StJohns <mstjohns@mindspring.com>
Subject: Re: ip_queue.c inefficiencies?
Date: Wed, 02 Feb 2005 16:18:04 +0100 [thread overview]
Message-ID: <4200EF2C.1030808@trash.net> (raw)
In-Reply-To: <20050201131128.GF6878@sunbeam.de.gnumonks.org>
Harald Welte wrote:
>On Tue, Jan 18, 2005 at 07:18:32PM -0500, Michael StJohns wrote:
>
>>The patch below does two things: It adds some /proc visible counters to
>>count the packets dropped because they couldn't be queued to either kernel
>>or user space; it adds a check early on in ipq_enqueue_packet to check and
>>see if the kernel queue is full before trying to send the packet to user
>>space.
>>
>
>I think your patch is perfectly valid and looks fine.
>
>Patrick, if you don't see any problems, could you add it to your queue
>of pending patches? Thanks!
>
The patch doesn't apply to current -bk. Michael, can you please send a new
patch against the latest -bk kernel ?
Regards
Patrick
next prev parent reply other threads:[~2005-02-02 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 0:18 ip_queue.c inefficiencies? Michael StJohns
2005-02-01 13:11 ` Harald Welte
2005-02-02 15:18 ` Patrick McHardy [this message]
[not found] ` <6.2.0.14.2.20050202105005.05278940@pop.mindspring.com>
2005-02-03 18:39 ` Patrick McHardy
2005-02-03 21:15 ` Michael StJohns
2005-02-04 5:02 ` Patrick McHardy
2005-02-04 23:01 ` Michael StJohns
2005-02-05 16:43 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4200EF2C.1030808@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=mstjohns@mindspring.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.