From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
Cc: Roland Mc Grath <roland@redhat.com>,
Jeff Dike <jdike@addtoit.com>,
BlaisorBlade <blaisorblade_spam@yahoo.it>,
user-mode-linux devel
<user-mode-linux-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: [uml-devel] Re: Race condition in ptrace
Date: Sat, 05 Feb 2005 09:15:40 +1100 [thread overview]
Message-ID: <4203F40C.8040707@yahoo.com.au> (raw)
In-Reply-To: <42036C2C.5040503@fujitsu-siemens.com>
Bodo Stroesser wrote:
> Nick Piggin wrote:
>
>> Bodo Stroesser wrote:
>> I don't see how this could help because AFAIKS, child->saving is only
>> set and cleared while the runqueue is locked. And the same runqueue lock
>> is taken by wait_task_inactive.
>>
>
> Sorry, that not right. There are some routines called by sched(), that
> release
> and reacquire the runqueue lock.
>
Oh yeah, it is the wake_sleeping_dependent / dependent_sleeper crap.
Sorry, you are right. And that's definitely a bug in sched.c, because
it breaks wait_task_inactive, as you've rightly observed.
Andrew, IMO this is another bug to hold 2.6.11 for.
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
Cc: Roland Mc Grath <roland@redhat.com>,
Jeff Dike <jdike@addtoit.com>,
BlaisorBlade <blaisorblade_spam@yahoo.it>,
user-mode-linux devel
<user-mode-linux-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: Race condition in ptrace
Date: Sat, 05 Feb 2005 09:15:40 +1100 [thread overview]
Message-ID: <4203F40C.8040707@yahoo.com.au> (raw)
In-Reply-To: <42036C2C.5040503@fujitsu-siemens.com>
Bodo Stroesser wrote:
> Nick Piggin wrote:
>
>> Bodo Stroesser wrote:
>> I don't see how this could help because AFAIKS, child->saving is only
>> set and cleared while the runqueue is locked. And the same runqueue lock
>> is taken by wait_task_inactive.
>>
>
> Sorry, that not right. There are some routines called by sched(), that
> release
> and reacquire the runqueue lock.
>
Oh yeah, it is the wake_sleeping_dependent / dependent_sleeper crap.
Sorry, you are right. And that's definitely a bug in sched.c, because
it breaks wait_task_inactive, as you've rightly observed.
Andrew, IMO this is another bug to hold 2.6.11 for.
next prev parent reply other threads:[~2005-02-04 22:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-03 12:51 [uml-devel] Race condition in ptrace Bodo Stroesser
2005-02-03 12:51 ` Bodo Stroesser
2005-02-04 0:27 ` [uml-devel] " Nick Piggin
2005-02-04 0:27 ` Nick Piggin
2005-02-04 12:35 ` [uml-devel] " Bodo Stroesser
2005-02-04 12:35 ` Bodo Stroesser
2005-02-04 22:15 ` Nick Piggin [this message]
2005-02-04 22:15 ` Nick Piggin
2005-02-04 22:39 ` [uml-devel] " Andrew Morton
2005-02-04 22:39 ` Andrew Morton
2005-02-04 23:15 ` [uml-devel] " Nick Piggin
2005-02-04 23:15 ` Nick Piggin
2005-02-05 4:35 ` [uml-devel] " Nick Piggin
2005-02-05 4:35 ` Nick Piggin
2005-02-06 3:26 ` [uml-devel] [PATCH] fix wait_task_inactive race (was Re: Race condition in ptrace) Nick Piggin
2005-02-06 3:26 ` Nick Piggin
2005-02-06 7:19 ` [uml-devel] " Ingo Molnar
2005-02-06 7:19 ` Ingo Molnar
2005-02-06 7:36 ` [uml-devel] " Nick Piggin
2005-02-06 7:36 ` Nick Piggin
2005-02-06 7:47 ` [uml-devel] " Nick Piggin
2005-02-06 7:47 ` Nick Piggin
2005-02-14 16:07 ` [uml-devel] " Bodo Stroesser
2005-02-14 16:07 ` Bodo Stroesser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4203F40C.8040707@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=blaisorblade_spam@yahoo.it \
--cc=bstroesser@fujitsu-siemens.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.