From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/8] ARM: shmobile: add a GPIO controller DT node for sh7372
Date: Mon, 21 Jan 2013 12:23:10 +0000 [thread overview]
Message-ID: <4209290.uCBdrcvT3q@avalon> (raw)
In-Reply-To: <1358356097-26180-6-git-send-email-g.liakhovetski@gmx.de>
Hi Guennadi,
Thanks for the patch.
On Wednesday 16 January 2013 18:08:14 Guennadi Liakhovetski wrote:
> Add a missing GPIO controller node to sh7372.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> arch/arm/boot/dts/sh7372.dtsi | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sh7372.dtsi b/arch/arm/boot/dts/sh7372.dtsi
> index 582fdec..7ca9322 100644
> --- a/arch/arm/boot/dts/sh7372.dtsi
> +++ b/arch/arm/boot/dts/sh7372.dtsi
> @@ -19,6 +19,14 @@
> };
> };
>
> + gpio: pfc@e6050000 {
> + compatible = "renesas,pfc-sh7372";
> + reg = <0xe6050000 0x8000>,
> + <0xe605800c 0x20>;
Shouldn't the second one be
<0xe605800c 0x1c>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
I haven't checked the board files, have you made sure that the PFC device
won't be instantiated twice, once from DT and once from board code ?
> soc {
> compatible = "simple-bus";
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] ARM: shmobile: add a GPIO controller DT node for sh7372
Date: Mon, 21 Jan 2013 13:23:10 +0100 [thread overview]
Message-ID: <4209290.uCBdrcvT3q@avalon> (raw)
In-Reply-To: <1358356097-26180-6-git-send-email-g.liakhovetski@gmx.de>
Hi Guennadi,
Thanks for the patch.
On Wednesday 16 January 2013 18:08:14 Guennadi Liakhovetski wrote:
> Add a missing GPIO controller node to sh7372.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> arch/arm/boot/dts/sh7372.dtsi | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sh7372.dtsi b/arch/arm/boot/dts/sh7372.dtsi
> index 582fdec..7ca9322 100644
> --- a/arch/arm/boot/dts/sh7372.dtsi
> +++ b/arch/arm/boot/dts/sh7372.dtsi
> @@ -19,6 +19,14 @@
> };
> };
>
> + gpio: pfc at e6050000 {
> + compatible = "renesas,pfc-sh7372";
> + reg = <0xe6050000 0x8000>,
> + <0xe605800c 0x20>;
Shouldn't the second one be
<0xe605800c 0x1c>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
I haven't checked the board files, have you made sure that the PFC device
won't be instantiated twice, once from DT and once from board code ?
> soc {
> compatible = "simple-bus";
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-01-21 12:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 17:08 [PATCH 0/8] ARM: shmobile: pinctrl and DT extensions Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-16 17:08 ` [PATCH 1/8] pinctrl: add SDHI and MMCIF pin groups to r8a7740 Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-17 10:04 ` [PATCH v2 " Guennadi Liakhovetski
2013-01-17 10:04 ` Guennadi Liakhovetski
2013-01-21 12:09 ` Laurent Pinchart
2013-01-21 12:09 ` Laurent Pinchart
2013-01-17 13:54 ` [PATCH " Linus Walleij
2013-01-17 13:54 ` Linus Walleij
2013-01-16 17:08 ` [PATCH 2/8] pinctrl: add SDHI and MMCIF pin groups to sh7372 Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-17 13:49 ` Linus Walleij
2013-01-17 13:49 ` Linus Walleij
2013-01-17 13:55 ` Guennadi Liakhovetski
2013-01-17 13:55 ` Guennadi Liakhovetski
2013-01-21 12:17 ` Laurent Pinchart
2013-01-21 12:17 ` Laurent Pinchart
2013-01-16 17:08 ` [PATCH 3/8] ARM: shmobile: simplify armadillo800eva and kzm9g Kconfig dependencies Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-16 17:08 ` [PATCH 4/8] ARM: shmobile: add MMCIF and SDHI DT clock aliases to sh73a0 and r8a7740 Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-16 17:08 ` [PATCH 5/8] ARM: shmobile: add a GPIO controller DT node for sh7372 Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-21 12:23 ` Laurent Pinchart [this message]
2013-01-21 12:23 ` Laurent Pinchart
2013-01-23 16:19 ` Guennadi Liakhovetski
2013-01-23 16:19 ` Guennadi Liakhovetski
2013-01-16 17:08 ` [PATCH 6/8] ARM: shmobile: use GPIO SD-card detection on armadillo800eva Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-16 17:08 ` [PATCH 7/8] ARM: shmobile: completely switch MMC interfaces on mackerel-reference to DT Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-16 17:08 ` [PATCH 8/8] ARM: shmobile: completely switch MMC interfaces on armadillo800eva-reference " Guennadi Liakhovetski
2013-01-16 17:08 ` Guennadi Liakhovetski
2013-01-17 6:04 ` [PATCH 0/8] ARM: shmobile: pinctrl and DT extensions Simon Horman
2013-01-17 6:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4209290.uCBdrcvT3q@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.