From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Reduction of compile warnings (Warning: long post
Date: Fri, 11 Feb 2005 13:45:20 +0000 [thread overview]
Message-ID: <420CB6F0.6090604@bfs.de> (raw)
In-Reply-To: <420953CC.2707.A99E9B@localhost>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
just my two cents ...
recruting helper variables will reduce linelenght and (sometimes)
improve readability.
e.g.:
feature=tf->feature | (((u16)tf->hob_feature) << 8 ;
writew(feature,(volatile void __iomem *)ioaddr->feature_addr);
btw:
is 'volatile' usefull here ? i would exspect that *ioaddr->feature_addr
is already defined 'volatile'.
( i do not have the code here, sorry if its to trivial.)
re,
walter
4. writew(tf->feature | (((u16)tf->hob_feature) << 8), (volatile
void __iomem *)ioaddr->feature_addr);
This line (and others) is just too long. Split it up at the comma
between the first & second parameters and then indent the second
line.
--
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-02-11 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-08 22:05 [KJ] [PATCH] Reduction of compile warnings (Warning: long post Stephen Biggs
2005-02-08 23:43 ` Jim Nelson
2005-02-09 7:29 ` Stephen Biggs
2005-02-09 8:22 ` Christophe Lucas
2005-02-09 10:43 ` Jim Nelson
2005-02-09 19:41 ` Stephen Biggs
2005-02-11 0:59 ` Randy.Dunlap
2005-02-11 13:45 ` walter harms [this message]
2005-02-11 13:51 ` Christoph Hellwig
2005-02-11 14:51 ` walter harms
2005-02-13 18:57 ` Stephen Biggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420CB6F0.6090604@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.