From: Paul Moore <paul@paul-moore.com>
To: David Howells <dhowells@redhat.com>
Cc: selinux@tycho.nsa.gov, netdev@vger.kernel.org
Subject: Re: [PATCH] SELinux: Fix RCU deref check warning in sel_netport_insert()
Date: Thu, 06 Oct 2011 18:51:19 -0400 [thread overview]
Message-ID: <4210290.EWfROnk5ys@sifl> (raw)
In-Reply-To: <1624.1317821523@redhat.com>
On Wednesday, October 05, 2011 02:32:03 PM David Howells wrote:
> Paul Moore <paul@paul-moore.com> wrote:
> > We should probably do the same for the security/selinux/netif.c as it
> > uses the same logic; David is this something you want to tackle?
>
> netif.c doesn't use any rcu_dereference*() function directly, though it does
> use list_for_each_entry_rcu(). However, I'm not sure that's a problem.
> What is it you're referring to?
My apologies, the netport.c and netif.c code is very, very similar and
whenever I see a patch just for one of the two it causes a reaction that you
saw above. While netif.c has a similar function, sel_netif_insert(), it is
slightly different and doesn't need a rcu_dereference() ad the netport.c code
does.
Sorry for the confusion.
--
paul moore
www.paul-moore.com
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul@paul-moore.com>
To: David Howells <dhowells@redhat.com>
Cc: selinux@tycho.nsa.gov, netdev@vger.kernel.org
Subject: Re: [PATCH] SELinux: Fix RCU deref check warning in sel_netport_insert()
Date: Thu, 06 Oct 2011 18:51:19 -0400 [thread overview]
Message-ID: <4210290.EWfROnk5ys@sifl> (raw)
In-Reply-To: <1624.1317821523@redhat.com>
On Wednesday, October 05, 2011 02:32:03 PM David Howells wrote:
> Paul Moore <paul@paul-moore.com> wrote:
> > We should probably do the same for the security/selinux/netif.c as it
> > uses the same logic; David is this something you want to tackle?
>
> netif.c doesn't use any rcu_dereference*() function directly, though it does
> use list_for_each_entry_rcu(). However, I'm not sure that's a problem.
> What is it you're referring to?
My apologies, the netport.c and netif.c code is very, very similar and
whenever I see a patch just for one of the two it causes a reaction that you
saw above. While netif.c has a similar function, sel_netif_insert(), it is
slightly different and doesn't need a rcu_dereference() ad the netport.c code
does.
Sorry for the confusion.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2011-10-06 22:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 13:58 [PATCH] SELinux: Fix RCU deref check warning in sel_netport_insert() David Howells
2011-10-03 13:58 ` David Howells
2011-10-03 21:30 ` Paul Moore
2011-10-03 21:30 ` Paul Moore
2011-10-03 23:07 ` David Howells
2011-10-03 23:07 ` David Howells
2011-10-04 0:06 ` Paul Moore
2011-10-04 0:06 ` Paul Moore
2011-10-04 4:22 ` Eric Dumazet
2011-10-05 11:07 ` David Howells
2011-10-05 11:07 ` David Howells
2011-10-05 13:32 ` David Howells
2011-10-05 13:32 ` David Howells
2011-10-06 22:51 ` Paul Moore [this message]
2011-10-06 22:51 ` Paul Moore
-- strict thread matches above, loose matches on Subject: below --
2011-12-13 14:49 David Howells
2011-12-13 23:11 ` James Morris
2011-12-16 13:13 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4210290.EWfROnk5ys@sifl \
--to=paul@paul-moore.com \
--cc=dhowells@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.