* [KJ] [PATCH][RESUBMIT][17/21] include/linux/* - compile warning
@ 2005-02-14 22:02 Stephen Biggs
2005-02-14 22:31 ` Greg KH
2005-02-15 6:41 ` Stephen Biggs
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Biggs @ 2005-02-14 22:02 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 1494 bytes --]
Description: compile warning cleanup - remove unmaintained rcs char
string, extinguish warning for module structure that is still live when
module is compiled into the kernel
Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/include/linux/ixjuser.h linux-2.6.11-rc3-mm2/include/linux/ixjuser.h
--- linux-2.6.11-rc3-mm2-original/include/linux/ixjuser.h 2004-12-24 23:35:50.000000000 +0200
+++ linux-2.6.11-rc3-mm2/include/linux/ixjuser.h 2005-02-14 00:20:59.399225704 +0200
@@ -42,7 +42,6 @@
*
*****************************************************************************/
-static char ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
#include <linux/telephony.h>
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/include/linux/module.h linux-2.6.11-rc3-mm2/include/linux/module.h
--- linux-2.6.11-rc3-mm2-original/include/linux/module.h 2005-02-12 12:06:39.000000000 +0200
+++ linux-2.6.11-rc3-mm2/include/linux/module.h 2005-02-13 23:23:16.000000000 +0200
@@ -84,7 +84,10 @@ extern const struct gtype##_id __mod_##g
extern struct module __this_module;
#define THIS_MODULE (&__this_module)
#else /* !MODULE */
-#define MODULE_GENERIC_TABLE(gtype,name)
+#define MODULE_GENERIC_TABLE(gtype,name) \
+extern const struct gtype##_id __not_mod_##name##_unused \
+ __attribute__ ((unused, weak, alias(__stringify(name))))
+
#define THIS_MODULE ((struct module *)0)
#endif
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ] [PATCH][RESUBMIT][17/21] include/linux/* - compile warning
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][17/21] include/linux/* - compile warning Stephen Biggs
@ 2005-02-14 22:31 ` Greg KH
2005-02-15 6:41 ` Stephen Biggs
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2005-02-14 22:31 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On Tue, Feb 15, 2005 at 12:02:53AM +0200, Stephen Biggs wrote:
> diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/include/linux/module.h linux-2.6.11-rc3-mm2/include/linux/module.h
> --- linux-2.6.11-rc3-mm2-original/include/linux/module.h 2005-02-12 12:06:39.000000000 +0200
> +++ linux-2.6.11-rc3-mm2/include/linux/module.h 2005-02-13 23:23:16.000000000 +0200
> @@ -84,7 +84,10 @@ extern const struct gtype##_id __mod_##g
> extern struct module __this_module;
> #define THIS_MODULE (&__this_module)
> #else /* !MODULE */
> -#define MODULE_GENERIC_TABLE(gtype,name)
> +#define MODULE_GENERIC_TABLE(gtype,name) \
> +extern const struct gtype##_id __not_mod_##name##_unused \
> + __attribute__ ((unused, weak, alias(__stringify(name))))
> +
> #define THIS_MODULE ((struct module *)0)
> #endif
Yeah, nice job with this.
But split it out into a separate patch (remember, one patch per
individual "thing" you want to change.)
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ] [PATCH][RESUBMIT][17/21] include/linux/* - compile warning
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][17/21] include/linux/* - compile warning Stephen Biggs
2005-02-14 22:31 ` Greg KH
@ 2005-02-15 6:41 ` Stephen Biggs
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Biggs @ 2005-02-15 6:41 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 1065 bytes --]
On 14 Feb 2005 at 14:31, Greg KH wrote:
> On Tue, Feb 15, 2005 at 12:02:53AM +0200, Stephen Biggs wrote:
> > diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/include/linux/module.h linux-2.6.11-rc3-mm2/include/linux/module.h
> > --- linux-2.6.11-rc3-mm2-original/include/linux/module.h 2005-02-12 12:06:39.000000000 +0200
> > +++ linux-2.6.11-rc3-mm2/include/linux/module.h 2005-02-13 23:23:16.000000000 +0200
> > @@ -84,7 +84,10 @@ extern const struct gtype##_id __mod_##g
> > extern struct module __this_module;
> > #define THIS_MODULE (&__this_module)
> > #else /* !MODULE */
> > -#define MODULE_GENERIC_TABLE(gtype,name)
> > +#define MODULE_GENERIC_TABLE(gtype,name) \
> > +extern const struct gtype##_id __not_mod_##name##_unused \
> > + __attribute__ ((unused, weak, alias(__stringify(name))))
> > +
> > #define THIS_MODULE ((struct module *)0)
> > #endif
>
> Yeah, nice job with this.
>
> But split it out into a separate patch (remember, one patch per
> individual "thing" you want to change.)
Done.
>
> thanks,
>
> greg k-h
>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-15 6:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][17/21] include/linux/* - compile warning Stephen Biggs
2005-02-14 22:31 ` Greg KH
2005-02-15 6:41 ` Stephen Biggs
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.