* [KJ] [PATCH][RESUBMIT][19/21] kernel/* - compile warning cleanup
@ 2005-02-14 22:02 Stephen Biggs
0 siblings, 0 replies; only message in thread
From: Stephen Biggs @ 2005-02-14 22:02 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 918 bytes --]
Description: compile warning cleanup - handle copy_to/from_user error
returns
Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/net/ipv6/ip6_flowlabel.c linux-2.6.11-rc3-mm2/net/ipv6/ip6_flowlabel.c
--- linux-2.6.11-rc3-mm2-original/net/ipv6/ip6_flowlabel.c 2005-02-12 12:06:27.000000000 +0200
+++ linux-2.6.11-rc3-mm2/net/ipv6/ip6_flowlabel.c 2005-02-12 19:17:48.000000000 +0200
@@ -537,9 +537,13 @@ release:
goto done;
/* Do not check for fault */
- if (!freq.flr_label)
- copy_to_user(&((struct in6_flowlabel_req __user *) optval)->flr_label,
- &fl->label, sizeof(fl->label));
+ if (!freq.flr_label) {
+ if (copy_to_user(&((struct in6_flowlabel_req __user *)optval)->flr_label,
+ &fl->label, sizeof(fl->label))) {
+ err = -EFAULT;
+ goto done;
+ }
+ }
sfl1->fl = fl;
sfl1->next = np->ipv6_fl_list;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-02-14 22:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][19/21] kernel/* - compile warning cleanup Stephen Biggs
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.