All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emmanuel Fleury <fleury-t5LvXY1cjzpaa/9Udqfwiw@public.gmane.org>
To: Stelian Pop <stelian-ibX4/ixPftWsTnJN9+BGXg@public.gmane.org>
Cc: Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH, new ACPI driver] new sony_acpi driver
Date: Wed, 16 Feb 2005 20:12:44 +0100	[thread overview]
Message-ID: <42139B2C.6040709@cs.aau.dk> (raw)
In-Reply-To: <20050211113636.GI3263-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>

Stelian Pop wrote:
> Based on feedback from Jean Delvare and Pekka Enberg, here is an
> updated version.
> 
> Changes from the previous version include:
> - do not initialize to 0 a static variable
> - trim to 80 columns
> - do not do spurious void * casts
> - use c99 style struct initialization
> - use simple_strtoul instead of sscanf
> - move documentation to new directory Documentation/acpi
> - name the file 'brightness' instead of 'brt'

Works straight for me (on a Vaio PCG-C1MZX), I can adjust brightness by
feeding the proc/ interface.

I have to try the debug mode.

Regards
-- 
Emmanuel Fleury

Computer Science Department, |  Office: B1-201
Aalborg University,          |  Phone:  +45 96 35 72 23
Fredriks Bajersvej 7E,       |  Fax:    +45 98 15 98 89
9220 Aalborg East, Denmark   |  Email:  fleury-t5LvXY1cjzpaa/9Udqfwiw@public.gmane.org


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

WARNING: multiple messages have this Message-ID (diff)
From: Emmanuel Fleury <fleury@cs.aau.dk>
To: Stelian Pop <stelian@popies.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH, new ACPI driver] new sony_acpi driver
Date: Wed, 16 Feb 2005 20:12:44 +0100	[thread overview]
Message-ID: <42139B2C.6040709@cs.aau.dk> (raw)
In-Reply-To: <20050211113636.GI3263@crusoe.alcove-fr>

Stelian Pop wrote:
> Based on feedback from Jean Delvare and Pekka Enberg, here is an
> updated version.
> 
> Changes from the previous version include:
> - do not initialize to 0 a static variable
> - trim to 80 columns
> - do not do spurious void * casts
> - use c99 style struct initialization
> - use simple_strtoul instead of sscanf
> - move documentation to new directory Documentation/acpi
> - name the file 'brightness' instead of 'brt'

Works straight for me (on a Vaio PCG-C1MZX), I can adjust brightness by
feeding the proc/ interface.

I have to try the debug mode.

Regards
-- 
Emmanuel Fleury

Computer Science Department, |  Office: B1-201
Aalborg University,          |  Phone:  +45 96 35 72 23
Fredriks Bajersvej 7E,       |  Fax:    +45 98 15 98 89
9220 Aalborg East, Denmark   |  Email:  fleury@cs.aau.dk

  parent reply	other threads:[~2005-02-16 19:12 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-10 16:18 [PATCH, new ACPI driver] new sony_acpi driver Stelian Pop
2005-02-10 16:18 ` Stelian Pop
2005-02-11 10:30 ` Jean Delvare
2005-02-11 11:17   ` Stelian Pop
     [not found] ` <20050210161809.GK3493-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-10 19:39   ` Bruno Ducrot
2005-02-10 19:39     ` [ACPI] " Bruno Ducrot
     [not found]     ` <20050210193937.GH1145-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2005-02-11  9:16       ` Stelian Pop
2005-02-11  9:16         ` [ACPI] " Stelian Pop
2005-02-11 11:05   ` Pekka Enberg
2005-02-11 11:05     ` Pekka Enberg
2005-02-11 11:36   ` Stelian Pop
2005-02-11 11:36     ` Stelian Pop
2005-02-11 12:02     ` Pekka Enberg
2005-02-12 13:21     ` Jean Delvare
     [not found]       ` <20050212142103.5e1a79f9.khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
2005-02-14 10:07         ` Stelian Pop
2005-02-14 10:07           ` Stelian Pop
2005-02-14 12:13           ` Jean Delvare
2005-02-14 12:38             ` Stelian Pop
2005-02-14 12:38               ` Stelian Pop
     [not found]               ` <20050214123822.GF3233-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-14 18:42                 ` Jean Delvare
2005-02-14 18:42                   ` Jean Delvare
     [not found]                   ` <20050214194235.073f5850.khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
2005-02-16 15:39                     ` Stelian Pop
2005-02-16 15:39                       ` Stelian Pop
     [not found]                       ` <20050216153924.GC4372-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-18 18:38                         ` Jean Delvare
2005-02-18 18:38                           ` Jean Delvare
     [not found]     ` <20050211113636.GI3263-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-16 19:12       ` Emmanuel Fleury [this message]
2005-02-16 19:12         ` Emmanuel Fleury
2005-02-15 15:30   ` Len Brown
2005-02-15 15:30     ` [ACPI] " Len Brown
2005-02-15 15:39     ` Stelian Pop
     [not found]       ` <20050215153912.GA3523-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-16 19:40         ` Bruno Ducrot
2005-02-16 19:40           ` [ACPI] " Bruno Ducrot
2005-02-14 10:53 ` Matthew Garrett
2005-02-14 10:58   ` Stelian Pop
     [not found]     ` <20050214105837.GE3233-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-14 20:32       ` Vojtech Pavlik
2005-02-14 20:32         ` Vojtech Pavlik
     [not found]         ` <20050214203211.GA8007-+ZI9xUNit7I@public.gmane.org>
2005-02-15 16:14           ` Romano Giannetti
2005-02-15 16:14             ` Romano Giannetti
     [not found]             ` <20050215161412.GC20951-NfIQswJzSEaq9fEpoSJUslHdEuJhDOxL@public.gmane.org>
2005-02-16 14:41               ` Stelian Pop
2005-02-16 14:41                 ` Stelian Pop
     [not found]                 ` <20050216144156.GA4372-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-16 15:40                   ` Romano Giannetti
2005-02-16 15:40                     ` Romano Giannetti
2005-02-16 23:18         ` [ACPI] " Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2005-03-15  6:07 Yu, Luming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42139B2C.6040709@cs.aau.dk \
    --to=fleury-t5lvxy1cjzpaa/9udqfwiw@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stelian-ibX4/ixPftWsTnJN9+BGXg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.