Suggestions for some patch-o-matic extensions (comment, ipp2p, random, etc...)

Suggestions for some patch-o-matic extensions (comment, ipp2p, random, etc...)

[Samuel Díaz García]

In some extensions, I detected that before I apply patch-o-matic (last 
source package) without problems, i can compile kernel and kernel 
modules fine.

But when I try to compile iptables, i have a common error with some 
extensions:
    error: near initialization for `<struct_name>.<struct_member>'

Some of these extensions are:
    * comment
    * ipp2p
    * random (IPv6)

Thinking about it, I had applied successfully these extensions over 
1.2.11 iptables version, but with 1.3.0, seems that some structure 
declaration has been changed and these modules don't compile without a 
manual user modification of the sources.

The "manual modification" should be an explicit member initialization in 
the struct, but some modules need more revision.

Here is the warning exposed.

Good Luck


--
    Samuel Díaz García
     Director Gerente
ArcosCom Wireless, S.L.L.

mailto:samueldg@arcoscom.com
http://www.arcoscom.com

Móvil: 651 93 72 48
Tlfn.: 956 70 13 15
Fax:   956 70 34 83

Re: Suggestions for some patch-o-matic extensions (comment, ipp2p, random, etc...)

[Samuel Díaz García]

I don't know how to use diff/patch utils to send you a patch to solve 
these issues, if anybody say me how to use them to create a valid patch 
file and send to the list.

I suppose that I need some rules over the file names and so on, say me 
and I post the patch.

I have the patched files too, but I don't know if I can send attached 
files to the list.
    Samuel Díaz García
     Director Gerente
ArcosCom Wireless, S.L.L.

mailto:samueldg@arcoscom.com
http://www.arcoscom.com

Móvil: 651 93 72 48
Tlfn.: 956 70 13 15
Fax:   956 70 34 83


Samuel Díaz García wrote:
> In some extensions, I detected that before I apply patch-o-matic (last 
> source package) without problems, i can compile kernel and kernel 
> modules fine.
> 
> But when I try to compile iptables, i have a common error with some 
> extensions:
>    error: near initialization for `<struct_name>.<struct_member>'
> 
> Some of these extensions are:
>    * comment
>    * ipp2p
>    * random (IPv6)
> 
> Thinking about it, I had applied successfully these extensions over 
> 1.2.11 iptables version, but with 1.3.0, seems that some structure 
> declaration has been changed and these modules don't compile without a 
> manual user modification of the sources.
> 
> The "manual modification" should be an explicit member initialization in 
> the struct, but some modules need more revision.
> 
> Here is the warning exposed.
> 
> Good Luck
> 
> 
> -- 
>    Samuel Díaz García
>     Director Gerente
> ArcosCom Wireless, S.L.L.
> 
> mailto:samueldg@arcoscom.com
> http://www.arcoscom.com
> 
> Móvil: 651 93 72 48
> Tlfn.: 956 70 13 15
> Fax:   956 70 34 83
> 
> 
> 

Re: Suggestions for some patch-o-matic extensions (comment, ipp2p, random, etc...)

[Samuel Jean]

Samuel Díaz García wrote:
> I don't know how to use diff/patch utils to send you a patch to solve 
> these issues, if anybody say me how to use them to create a valid patch 
> file and send to the list.

Hi Samuel,

Well, first off. Please post such subject on the
netfilter-devel@lists.netfilter.org

> 
> I suppose that I need some rules over the file names and so on, say me 
> and I post the patch.

If you are going to patch kernel part.. uhm. if you are going to patch
at all, please read Documentation/SubmittingPatches and CodingStyle.

(from linux kernel source)

> 
> I have the patched files too, but I don't know if I can send attached 
> files to the list.

Well, that should be the really _last_ thing you do. Prior to this,
you should :

1. Post the complete errors you got
2. Manage to make some patches

Oh! Here's a good reading :
http://www.csn.ul.ie/~mel/projects/vm/guide/html/understand/node13.html#SECTION00611000000000000000

>    Samuel Díaz García
>     Director Gerente
> ArcosCom Wireless, S.L.L.

Thanks a lot,
Samuel

Re: Suggestions for some patch-o-matic extensions (comment, ipp2p, random, etc...)

[Samuel Jean]

Samuel Díaz García wrote:
> Well, I have 3 iptables extensions patched for the use with iptables 1.3.0.
> 
> libipt_comment.c
> libipt_ipp2p.c
> libip6t_random.c
> 
> They are compiling fine now (after I done some changes in the "struct 
> iptables_match" variable definition.
> 
> The way to correct compile errors is revise the "struct iptables_match" 
> variable definition.

Please take a look at :
https://lists.netfilter.org/pipermail/netfilter-devel/2005-February/018468.html

comment and ipp2p are done yet.

Patch for 6_random is, I guess, welcome.

 > [...]
> 
>    Samuel Díaz García
>     Director Gerente
> ArcosCom Wireless, S.L.L.


Best regards,
Samuel