[Fwd: ipt_connlimit.c from pom-ng contains error]

[Fwd: ipt_connlimit.c from pom-ng contains error]

[Rusty Russell]

-------- Forwarded Message --------
From: Zharovtsev, Anton <warm@stack.ru>
To: rusty@rustcorp.com.au
Subject: ipt_connlimit.c from pom-ng contains error
Date: Wed, 16 Feb 2005 13:02:25 +0600
Hello.

I am sorry for writing this letter directly to You and not to the mail list.
I have no time to subcribe and so on ...


This is from 2.4 linux/netfilter_ipv4/ip_conntrack.h:

        /* Our various nf_ct_info structs specify *what* relation this
           packet has to the conntrack */
        struct nf_ct_info infos[IP_CT_NUMBER];

There is no description of such member of struct ip_conntrack in the 2.6 same file ( linux/netfilter_ipv4/ip_conntrack.h )

I am not a programmer, I only applied pom-ng for 2005-02-14 date onto 2.6.10 kernel and I got error:

  CC [M]  net/ipv4/netfilter/ipt_connlimit.o
net/ipv4/netfilter/ipt_connlimit.c: In function `count_them':
net/ipv4/netfilter/ipt_connlimit.c:100: error: structure has no member named `infos'
net/ipv4/netfilter/ipt_connlimit.c:107: error: structure has no member named `infos'
make[3]: *** [net/ipv4/netfilter/ipt_connlimit.o] Ошибка 1
make[2]: *** [net/ipv4/netfilter] Error 2
make[1]: *** [net/ipv4] Error 2
make: *** [net] Error 2
root@wasp:/usr/src/linux#

I will turn off this module, but I think it is very usefull for many peoples and.
This letter is my small bug report :-).

Sorry again.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

Re: [Fwd: ipt_connlimit.c from pom-ng contains error]

[Samuel Jean]

Rusty Russell wrote:
> -------- Forwarded Message --------
> From: Zharovtsev, Anton <warm@stack.ru>
> To: rusty@rustcorp.com.au
> Subject: ipt_connlimit.c from pom-ng contains error
> Date: Wed, 16 Feb 2005 13:02:25 +0600
> Hello.
> 
> [...]
>   CC [M]  net/ipv4/netfilter/ipt_connlimit.o
> net/ipv4/netfilter/ipt_connlimit.c: In function `count_them':
> net/ipv4/netfilter/ipt_connlimit.c:100: error: structure has no member named `infos'
> net/ipv4/netfilter/ipt_connlimit.c:107: error: structure has no member named `infos'
> make[3]: *** [net/ipv4/netfilter/ipt_connlimit.o] Ошибка 1
> make[2]: *** [net/ipv4/netfilter] Error 2
> make[1]: *** [net/ipv4] Error 2
> make: *** [net] Error 2
> root@wasp:/usr/src/linux#

Anton, this bug has been fixed according to bugzilla :

https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=268

> 
> I will turn off this module, but I think it is very usefull for many peoples and.
> This letter is my small bug report :-).

Harald applied it against the 2.6 branch. Just check out the module from there and you are done.

svn co http://svn.netfilter.org/netfilter/branches/patch-o-matic-ng/linux-2.6.11/connlimit

> 
> Sorry again.

Best regards,
Samuel