Re: [PATCH] (1/3) cpufreq_ondemand - 01_ignore-nice.diff

[Eric Piel <Eric.Piel@tremplin-utc.net>]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

Eric Piel a écrit :
> Alexander Clouter a écrit :
> 
>> Adds support to cpufreq_ondemand to ignore 'nice' cpu time
>>
> IMO, this policy should be has lightweight as possible. Why not making 
> this feature just hard-coded? Don't count the load that nice'd tasks do, 
> period!
> 
> It would make the patch 5 lines instead of 50. Every userspace deamon 
> have this feature enabled by default, so this is a very reasonable 
> trade-off.
> 
Here is the patch, it does exactly the same functionality but it's 
completly static and therefore much smaller. Just tested on my computer, 
it does the trick.

Eric
--
Avoid the cpufreq ondemand governor to count the nice'd tasks as load 
for the cpu.

  cpufreq_ondemand.c |   17 ++++++++++-------
  1 files changed, 10 insertions(+), 7 deletions(-)

Signed-off-by: Eric Piel <eric.piel@tremplin-utc.net>
--

[-- Attachment #2: ondemand-ignore-nice-static.patch --]
[-- Type: text/x-patch, Size: 2197 bytes --]

--- linux-2.6.11-rc4/drivers/cpufreq/cpufreq_ondemand.c.bak	2005-02-06 23:35:41.000000000 +0100
+++ linux-2.6.11-rc4/drivers/cpufreq/cpufreq_ondemand.c	2005-02-21 11:10:26.000000000 +0100
@@ -253,7 +253,8 @@ static void dbs_check_cpu(int cpu)
 
 	/* Check for frequency increase */
 	total_idle_ticks = kstat_cpu(cpu).cpustat.idle +
-		kstat_cpu(cpu).cpustat.iowait;
+		kstat_cpu(cpu).cpustat.iowait +
+		kstat_cpu(cpu).cpustat.nice;
 	idle_ticks = total_idle_ticks -
 		this_dbs_info->prev_cpu_idle_up;
 	this_dbs_info->prev_cpu_idle_up = total_idle_ticks;
@@ -269,7 +270,8 @@ static void dbs_check_cpu(int cpu)
 		j_dbs_info = &per_cpu(cpu_dbs_info, j);
 		/* Check for frequency increase */
 		total_idle_ticks = kstat_cpu(j).cpustat.idle +
-			kstat_cpu(j).cpustat.iowait;
+			kstat_cpu(j).cpustat.iowait +
+			kstat_cpu(j).cpustat.nice;
 		tmp_idle_ticks = total_idle_ticks -
 			j_dbs_info->prev_cpu_idle_up;
 		j_dbs_info->prev_cpu_idle_up = total_idle_ticks;
@@ -297,7 +299,8 @@ static void dbs_check_cpu(int cpu)
 		return;
 
 	total_idle_ticks = kstat_cpu(cpu).cpustat.idle +
-		kstat_cpu(cpu).cpustat.iowait;
+		kstat_cpu(cpu).cpustat.iowait +
+		kstat_cpu(cpu).cpustat.nice;
 	idle_ticks = total_idle_ticks -
 		this_dbs_info->prev_cpu_idle_down;
 	this_dbs_info->prev_cpu_idle_down = total_idle_ticks;
@@ -312,7 +315,8 @@ static void dbs_check_cpu(int cpu)
 		j_dbs_info = &per_cpu(cpu_dbs_info, j);
 		/* Check for frequency increase */
 		total_idle_ticks = kstat_cpu(j).cpustat.idle +
-			kstat_cpu(j).cpustat.iowait;
+			kstat_cpu(j).cpustat.iowait +
+			kstat_cpu(j).cpustat.nice;
 		tmp_idle_ticks = total_idle_ticks -
 			j_dbs_info->prev_cpu_idle_down;
 		j_dbs_info->prev_cpu_idle_down = total_idle_ticks;
@@ -398,11 +402,10 @@ static int cpufreq_governor_dbs(struct c
 			j_dbs_info->cur_policy = policy;
 		
 			j_dbs_info->prev_cpu_idle_up = 
-				kstat_cpu(j).cpustat.idle +
-				kstat_cpu(j).cpustat.iowait;
 			j_dbs_info->prev_cpu_idle_down = 
 				kstat_cpu(j).cpustat.idle +
-				kstat_cpu(j).cpustat.iowait;
+				kstat_cpu(j).cpustat.iowait +
+				kstat_cpu(j).cpustat.nice;
 		}
 		this_dbs_info->enable = 1;
 		sysfs_create_group(&policy->kobj, &dbs_attr_group);

[-- Attachment #3: Type: text/plain, Size: 147 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@lists.linux.org.uk
http://lists.linux.org.uk/mailman/listinfo/cpufreq