Re: A reorganization of Xen sources is necessary before integrating Xen into Linux.

Re: A reorganization of Xen sources is necessary before integrating Xen into Linux.

[Arun Sharma]

On 2/21/2005 8:14 AM, Philippe Berthault wrote:
> I have searched assembly code in Xen sources (xen-unstable)
> and I'm very surprised because the assembly code isn't located
> in 'arch' directories.
>
> [..]
>   - tools/ioemu/iodev

Yes, that one is my fault. The main issue is that we don't have a common place to put arch specific definitions accessible from user space. This came up in the other thread related to rmb/wmb as well.

If we agree that: <asm/xc.h> or <bits/xc.h> is the right thing to do, I'll be happy to submit patches.

	-Arun


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

A reorganization of Xen sources is necessary before integrating Xen into Linux.

[Philippe Berthault]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

I have searched assembly code in Xen sources (xen-unstable)
and I'm very surprised because the assembly code isn't located
in 'arch' directories.

I have found assembly code in the following directories:
  - extras/mini-os
  - linux-2.6.10-xen-sparse/drivers/xen/privcmd
  - tools/blktap
  - tools/ioemu/iodev
  - tools/libxc
  - tools/python/xen/lowlevel/xu
  - tools/x2d2
  - tools/xcs

All these assembly code seems to be specific to IA32.
So porting Xen to a new architecture (such as IA64) will be acrobatic !

Is there a plan to reorganize source code into a better and cleanest
architecture ?
I thinks this would be mandatory before integrating Xen into Linux.

PhB

[-- Attachment #2: Type: text/html, Size: 3027 bytes --]

Re: A reorganization of Xen sources is necessary before integrating Xen into Linux.

[Keir Fraser]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]


On 21 Feb 2005, at 16:14, Philippe Berthault wrote:

> I have searched assembly code in Xen sources (xen-unstable)
> and I'm very surprised because the assembly code isn't located
> in 'arch' directories.

Clean-up work is ongoing -- you'll notice that Xen itself contains no 
assembly code, or other arch-specific routines, outside the arch 
subdirectories. The particular XenLinux file you point out is our one 
rather arch-specific driver -- that one is likely to get moved to 
arch/xen/i386 at some point. There is some work to be done on the 
tools: no architecture apart from x86 currently uses them.

> Is there a plan to reorganize source code into a better and cleanest
> architecture ?
> I thinks this would be mandatory before integrating Xen into Linux.

Xen and XenLinux are already clean (apart from that one driver file), 
so this is not a barrier to getting our Linux changes integrated into 
the mainline repository.

  -- Keir

[-- Attachment #2: Type: text/enriched, Size: 1361 bytes --]



On 21 Feb 2005, at 16:14, Philippe Berthault wrote:


<excerpt><fontfamily><param>Arial</param><smaller>I have searched
assembly code in Xen sources (xen-unstable)</smaller></fontfamily>

<fontfamily><param>Arial</param><smaller>and I'm very surprised
because the assembly code isn't located</smaller></fontfamily>

<fontfamily><param>Arial</param><smaller>in 'arch' directories.</smaller></fontfamily>

</excerpt>

Clean-up work is ongoing -- you'll notice that Xen itself contains no
assembly code, or other arch-specific routines, outside the arch
subdirectories. The particular XenLinux file you point out is our one
rather arch-specific driver -- that one is likely to get moved to
arch/xen/i386 at some point. There is some work to be done on the
tools: no architecture apart from x86 currently uses them.


<excerpt><fontfamily><param>Arial</param><smaller>Is there a plan to
reorganize source code into a better and cleanest</smaller></fontfamily>

<fontfamily><param>Arial</param><smaller>architecture ?</smaller></fontfamily>

<fontfamily><param>Arial</param><smaller>I thinks this would be
mandatory before integrating Xen into Linux.</smaller></fontfamily>

</excerpt>

Xen and XenLinux are already clean (apart from that one driver file),
so this is not a barrier to getting our Linux changes integrated into
the mainline repository.


 -- Keir