From: "Buttchereit, Axel (XL)" <XL@XLsigned.net>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Olaf Hering <olh@suse.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Re: 2.6.11-rc5
Date: Sat, 26 Feb 2005 02:08:09 +0100 [thread overview]
Message-ID: <421FCBF9.1020003@XLsigned.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0502251648420.9237@ppc970.osdl.org>
Linus Torvalds wrote:
>
> On Sat, 26 Feb 2005, Olaf Hering wrote:
>
>>modedb can not be __init because fb_find_mode() may get db == NULL.
>>fb_find_mode() is called from modules.
>
>
> Ack. Maybe somebody should run the scripts again to check that we don't
> reference __init data from non-init functions.
>
> Linus
>
This patch has already been posted to linux-fbdev on 2005-02-10 by David Vrabel
and made me ask
Is there any reason why this has been originally flagged "__init"?
"vesa_modes" is not "__init". That's why I changed "intelfb" to
use "vesa_modes".
Maybe time has come to decide, if availability of "modedb" outside
of init functions is more important than freeing (unused) kernel memory.
--Axel
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
WARNING: multiple messages have this Message-ID (diff)
From: "Buttchereit, Axel (XL)" <XL@XLsigned.net>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Olaf Hering <olh@suse.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-fbdev-devel] Re: 2.6.11-rc5
Date: Sat, 26 Feb 2005 02:08:09 +0100 [thread overview]
Message-ID: <421FCBF9.1020003@XLsigned.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0502251648420.9237@ppc970.osdl.org>
Linus Torvalds wrote:
>
> On Sat, 26 Feb 2005, Olaf Hering wrote:
>
>>modedb can not be __init because fb_find_mode() may get db == NULL.
>>fb_find_mode() is called from modules.
>
>
> Ack. Maybe somebody should run the scripts again to check that we don't
> reference __init data from non-init functions.
>
> Linus
>
This patch has already been posted to linux-fbdev on 2005-02-10 by David Vrabel
and made me ask
Is there any reason why this has been originally flagged "__init"?
"vesa_modes" is not "__init". That's why I changed "intelfb" to
use "vesa_modes".
Maybe time has come to decide, if availability of "modedb" outside
of init functions is more important than freeing (unused) kernel memory.
--Axel
next prev parent reply other threads:[~2005-02-26 1:08 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 4:18 2.6.11-rc5 Linus Torvalds
2005-02-24 6:24 ` 2.6.11-rc5 Michael Neuffer
2005-02-24 15:49 ` 2.6.11-rc5 Linus Torvalds
2005-02-24 6:29 ` 2.6.11-rc5 Matt Mackall
2005-02-24 12:49 ` 2.6.11-rc5 Matthias-Christian Ott
2005-02-24 14:25 ` 2.6.11-rc5 Steven Rostedt
2005-02-24 14:57 ` 2.6.11-rc5 M.Baris Demiray
2005-02-24 15:39 ` 2.6.11-rc5 Sergey Vlasov
2005-02-24 15:57 ` 2.6.11-rc5 Steven Rostedt
2005-02-24 15:53 ` 2.6.11-rc5 Gabriel Paubert
2005-02-24 14:50 ` 2.6.11-rc5 Olaf Hering
2005-02-24 17:14 ` 2.6.11-rc5 Olaf Hering
2005-02-24 23:28 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-25 7:08 ` 2.6.11-rc5 Olaf Hering
2005-02-25 7:29 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-25 13:30 ` 2.6.11-rc5 Mws
2005-02-26 0:50 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-03-01 11:36 ` 2.6.11-rc5 Mws
2005-03-01 14:36 ` 2.6.11-rc5 Helge Hafting
2005-03-01 14:39 ` 2.6.11-rc5 Mws
2005-03-01 21:38 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-03-01 22:01 ` 2.6.11-rc5 Mws
2005-02-25 17:29 ` 2.6.11-rc5 Olaf Hering
2005-02-25 17:59 ` [Linux-fbdev-devel] 2.6.11-rc5 James Simmons
2005-02-25 20:24 ` Olaf Hering
2005-02-25 20:24 ` [Linux-fbdev-devel] " Olaf Hering
2005-02-25 21:21 ` Olaf Hering
2005-02-25 23:30 ` Olaf Hering
2005-02-26 1:01 ` Benjamin Herrenschmidt
2005-02-26 1:01 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2005-02-26 9:52 ` Giuseppe Bilotta
2005-02-26 0:58 ` Benjamin Herrenschmidt
2005-02-26 0:58 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2005-02-26 0:57 ` Benjamin Herrenschmidt
2005-02-26 0:57 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2005-02-26 0:54 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-26 0:41 ` 2.6.11-rc5 Olaf Hering
2005-02-26 0:41 ` 2.6.11-rc5 Olaf Hering
2005-02-26 0:49 ` 2.6.11-rc5 Linus Torvalds
2005-02-26 0:53 ` 2.6.11-rc5 Olaf Hering
2005-02-26 1:04 ` 2.6.11-rc5 Linus Torvalds
2005-02-26 1:04 ` 2.6.11-rc5 Linus Torvalds
2005-02-26 1:08 ` Buttchereit, Axel (XL) [this message]
2005-02-26 1:08 ` [Linux-fbdev-devel] 2.6.11-rc5 Buttchereit, Axel (XL)
2005-02-26 1:17 ` Benjamin Herrenschmidt
2005-02-26 1:13 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-26 1:13 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-26 7:41 ` [Linux-fbdev-devel] 2.6.11-rc5 Antonino A. Daplas
2005-02-26 7:41 ` Antonino A. Daplas
2005-02-27 8:07 ` 2.6.11-rc5 Geert Uytterhoeven
2005-02-27 8:07 ` 2.6.11-rc5 Geert Uytterhoeven
2005-02-24 15:57 ` 2.6.11-rc5 (compile stats) John Cherry
2005-02-24 16:30 ` 2.6.11-rc5 Brian Gerst
2005-02-24 17:00 ` 2.6.11-rc5 Linus Torvalds
2005-02-25 21:47 ` 2.6.11-rc5 Bill Davidsen
2005-02-25 21:50 ` 2.6.11-rc5 Lee Revell
2005-02-26 5:03 ` 2.6.11-rc5 Bill Davidsen
2005-02-27 20:32 ` 2.6.11-rc5, rivafb i2c oops, bogus error handling Olaf Hering
2005-02-27 20:32 ` Olaf Hering
2005-02-28 14:41 ` Antonino A. Daplas
2005-02-28 14:41 ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-03-01 12:02 ` Olaf Hering
2005-03-01 20:58 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421FCBF9.1020003@XLsigned.net \
--to=xl@xlsigned.net \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.