[PATCH] procfs: fix printk format warning

[PATCH] procfs: fix printk format warning

[Randy.Dunlap]

sparc: fix printk format warning:
fs/proc/proc_misc.c:195: warning: long unsigned int format, unsigned int arg (arg 23)

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat: include/asm-sparc/vaddrs.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -Naurp ./include/asm-sparc/vaddrs.h~proc_misc_printk ./include/asm-sparc/vaddrs.h
--- ./include/asm-sparc/vaddrs.h~proc_misc_printk	2004-12-24 13:33:49.000000000 -0800
+++ ./include/asm-sparc/vaddrs.h	2005-03-01 16:58:02.249595144 -0800
@@ -35,10 +35,10 @@
 #define IOBASE_VADDR		0xfe000000
 #define IOBASE_END		0xfe600000
 
-#define VMALLOC_START		0xfe600000
+#define VMALLOC_START		0xfe600000UL
 
 /* XXX Alter this when I get around to fixing sun4c - Anton */
-#define VMALLOC_END		0xffc00000
+#define VMALLOC_END		0xffc00000UL
 
 /*
  * On the sun4/4c we need a place

---

Re: [PATCH] procfs: fix printk format warning

[William Lee Irwin III]

On Tue, Mar 01, 2005 at 09:10:05PM -0800, Randy.Dunlap wrote:
> sparc: fix printk format warning:
> fs/proc/proc_misc.c:195: warning: long unsigned int format, unsigned int arg (arg 23)
> Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
> diffstat:>  include/asm-sparc/vaddrs.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

The UL qualifier can't be used directly as VMALLOC_START is used in
assembly (check arch/sparc/kernel/entry.S).


-- wli

Re: [PATCH] procfs: fix printk format warning

[Randy.Dunlap]

William Lee Irwin III wrote:
> On Tue, Mar 01, 2005 at 09:10:05PM -0800, Randy.Dunlap wrote:
> 
>>sparc: fix printk format warning:
>>fs/proc/proc_misc.c:195: warning: long unsigned int format, unsigned int arg (arg 23)
>>Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
>>diffstat:>> include/asm-sparc/vaddrs.h |    4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> The UL qualifier can't be used directly as VMALLOC_START is used in
> assembly (check arch/sparc/kernel/entry.S).

Darn, that gives me some lack of confidence in my cross-build
tools.  Cross-build results are at:
https://www.osdl.org/plm-cgi/plm?module=patch_info&patch_idB38
and sparc build with this patch passed....

But I do trust that you know what you are talking about and
that I probably have a toolchain problem.

-- 
~Randy

Re: [PATCH] procfs: fix printk format warning

[William Lee Irwin III]

William Lee Irwin III wrote:
>> The UL qualifier can't be used directly as VMALLOC_START is used in
>> assembly (check arch/sparc/kernel/entry.S).

On Wed, Mar 02, 2005 at 06:49:05PM -0800, Randy.Dunlap wrote:
> Darn, that gives me some lack of confidence in my cross-build
> tools.  Cross-build results are at:
> https://www.osdl.org/plm-cgi/plm?module=patch_info&patch_idB38
> and sparc build with this patch passed....
> But I do trust that you know what you are talking about and
> that I probably have a toolchain problem.

Okay, in that case, I wonder why it worked.


-- wli