[PATCH]: fixed the bug of tracking TCP sequence number in ftp module

[PATCH]: fixed the bug of tracking TCP sequence number in ftp module

[Yasuyuki KOZAKAI]

[-- Attachment #1: Type: Text/Plain, Size: 246 bytes --]


Hi,

TCP sequence number is 32bits.

Signed-off-by: Yasuyuki KOZAKAI <yasuyuki.kozkaai@toshiba.co.jp>

Regards,

-----------------------------------------------------------------
Yasuyuki KOZAKAI @ USAGI Project <yasuyuki.kozakai@toshiba.co.jp>

[-- Attachment #2: ct_ftp_seq.patch --]
[-- Type: Text/Plain, Size: 734 bytes --]

--- linux-2.6.11/net/ipv4/netfilter/ip_conntrack_ftp.c	2005-03-10 05:48:22.000000000 +0900
+++ linux-2.6.11-fixed/net/ipv4/netfilter/ip_conntrack_ftp.c	2005-03-10 05:54:30.000000000 +0900
@@ -252,7 +252,7 @@
 }
 
 /* Look up to see if we're just after a \n. */
-static int find_nl_seq(u16 seq, const struct ip_ct_ftp_master *info, int dir)
+static int find_nl_seq(u32 seq, const struct ip_ct_ftp_master *info, int dir)
 {
 	unsigned int i;
 
@@ -263,7 +263,7 @@
 }
 
 /* We don't update if it's older than what we have. */
-static void update_nl_seq(u16 nl_seq, struct ip_ct_ftp_master *info, int dir)
+static void update_nl_seq(u32 nl_seq, struct ip_ct_ftp_master *info, int dir)
 {
 	unsigned int i, oldest = NUM_SEQ_TO_REMEMBER;
 

Re: [PATCH]: fixed the bug of tracking TCP sequence number in ftp module

[Patrick McHardy]

Yasuyuki KOZAKAI wrote:
> TCP sequence number is 32bits.

Also applied, thanks.

Regards
Patrick

Re: [PATCH]: fixed the bug of tracking TCP sequence number in ftp module

[Patrick McHardy]

Yasuyuki KOZAKAI wrote:

> TCP sequence number is 32bits. 

BTW, I have a nf_conntrack tree outside of patch-o-matic to get it ready
for submission. I haven't exported it anywhere public yet, but since
you're updating nf_conntrack anyway, it would be great if you could also
send patches for nf_conntrack against your tree together with
ip_conntrack patches. I'll try to export my tree somewhere this
weekend.

Thanks,
Patrick

Re: [PATCH]: fixed the bug of tracking TCP sequence number in ftp module

[Yasuyuki KOZAKAI]

From: Patrick McHardy <kaber@trash.net>
Date: Thu, 10 Mar 2005 02:53:15 +0100

> Yasuyuki KOZAKAI wrote:
> 
> > TCP sequence number is 32bits. 
> 
> BTW, I have a nf_conntrack tree outside of patch-o-matic to get it ready
> for submission. I haven't exported it anywhere public yet, but since
> you're updating nf_conntrack anyway, it would be great if you could also
> send patches for nf_conntrack against your tree together with
> ip_conntrack patches. I'll try to export my tree somewhere this
> weekend.

I see. Maybe I need to fix about 3 or 4 issues.

-----------------------------------------------------------------
Yasuyuki KOZAKAI @ USAGI Project <yasuyuki.kozakai@toshiba.co.jp>