All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh@kernel.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: gyro: Add MPU-3050 device tree bindings
Date: Sun, 21 Aug 2016 12:13:20 +0100	[thread overview]
Message-ID: <42334499-131e-eca7-1d8f-86fe2585f0cf@kernel.org> (raw)
In-Reply-To: <CACRpkdacvNPsQPY41odrqfPPbuxVJ8wWNR1yqBXi4inMuhEr3w@mail.gmail.com>

On 16/08/16 20:33, Linus Walleij wrote:
> On Tue, Aug 16, 2016 at 4:28 PM, Rob Herring <robh@kernel.org> wrote:
>> On Mon, Aug 15, 2016 at 08:37:55PM +0200, Linus Walleij wrote:
>>> This adds device tree bindings for the MPU-3050 gyroscope. Since it
>>> is the first set of bindings for a gyroscope, the folder for it
>>> is also created.
>>
>> Is this not similar to mpu-6050 and other Invsense devices:
>>
>> Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt
> 
> I guess it was a precursor.
> 
> The MPU-3050 is a pure gyroscope, the MPU-6050 combines
> the gyro with an accelerometer. That is why it is classified as
> an IMU rather than a gyro.
> 
I did wonder if the 3050 was a subset of the 6050 but the
register maps are clearly totally different. Hence any sort
of unified driver would be a mess on any OS.

Probably fair to keep the binding docs separate (though in
sync where it makes sense!)

Jonathan


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] iio: gyro: Add MPU-3050 device tree bindings
Date: Sun, 21 Aug 2016 12:13:20 +0100	[thread overview]
Message-ID: <42334499-131e-eca7-1d8f-86fe2585f0cf@kernel.org> (raw)
In-Reply-To: <CACRpkdacvNPsQPY41odrqfPPbuxVJ8wWNR1yqBXi4inMuhEr3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 16/08/16 20:33, Linus Walleij wrote:
> On Tue, Aug 16, 2016 at 4:28 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>> On Mon, Aug 15, 2016 at 08:37:55PM +0200, Linus Walleij wrote:
>>> This adds device tree bindings for the MPU-3050 gyroscope. Since it
>>> is the first set of bindings for a gyroscope, the folder for it
>>> is also created.
>>
>> Is this not similar to mpu-6050 and other Invsense devices:
>>
>> Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt
> 
> I guess it was a precursor.
> 
> The MPU-3050 is a pure gyroscope, the MPU-6050 combines
> the gyro with an accelerometer. That is why it is classified as
> an IMU rather than a gyro.
> 
I did wonder if the 3050 was a subset of the 6050 but the
register maps are clearly totally different. Hence any sort
of unified driver would be a mess on any OS.

Probably fair to keep the binding docs separate (though in
sync where it makes sense!)

Jonathan

  reply	other threads:[~2016-08-21 11:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15 18:37 [PATCH 1/2] iio: gyro: Add MPU-3050 device tree bindings Linus Walleij
2016-08-15 18:37 ` Linus Walleij
2016-08-16 14:28 ` Rob Herring
2016-08-16 14:28   ` Rob Herring
2016-08-16 19:33   ` Linus Walleij
2016-08-16 19:33     ` Linus Walleij
2016-08-21 11:13     ` Jonathan Cameron [this message]
2016-08-21 11:13       ` Jonathan Cameron
2016-08-21 16:08 ` Jonathan Cameron
2016-08-21 16:08   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42334499-131e-eca7-1d8f-86fe2585f0cf@kernel.org \
    --to=jic23@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.