* [PATCH] procfs: convert to C99 inits.
@ 2005-03-15 0:03 Randy.Dunlap
2005-03-15 0:15 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Randy.Dunlap @ 2005-03-15 0:03 UTC (permalink / raw)
To: lkml; +Cc: akpm
(resend)
Use C99 struct inits as requested by sparse:
fs/proc/base.c:738:2: warning: obsolete struct initializer, use C99 syntax
fs/proc/base.c:739:2: warning: obsolete struct initializer, use C99 syntax
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
fs/proc/base.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Naurp ./fs/proc/base.c~proc_c99_inits ./fs/proc/base.c
--- ./fs/proc/base.c~proc_c99_inits 2005-02-15 13:48:46.310312808 -0800
+++ ./fs/proc/base.c 2005-02-15 20:34:41.335786152 -0800
@@ -735,8 +735,8 @@ static ssize_t oom_adjust_write(struct f
}
static struct file_operations proc_oom_adjust_operations = {
- read: oom_adjust_read,
- write: oom_adjust_write,
+ .read = oom_adjust_read,
+ .write = oom_adjust_write,
};
static struct inode_operations proc_mem_inode_operations = {
---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] procfs: convert to C99 inits.
2005-03-15 0:03 [PATCH] procfs: convert to C99 inits Randy.Dunlap
@ 2005-03-15 0:15 ` Ben Dooks
2005-03-15 0:19 ` Randy.Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2005-03-15 0:15 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: lkml, akpm
On Mon, Mar 14, 2005 at 04:03:29PM -0800, Randy.Dunlap wrote:
> (resend)
>
> Use C99 struct inits as requested by sparse:
> fs/proc/base.c:738:2: warning: obsolete struct initializer, use C99 syntax
> fs/proc/base.c:739:2: warning: obsolete struct initializer, use C99 syntax
I posted a patch for this, and an included `__user` missing
from the self-same set of functions a short while ago.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] procfs: convert to C99 inits.
2005-03-15 0:15 ` Ben Dooks
@ 2005-03-15 0:19 ` Randy.Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy.Dunlap @ 2005-03-15 0:19 UTC (permalink / raw)
To: Ben Dooks; +Cc: lkml, akpm
Ben Dooks wrote:
> On Mon, Mar 14, 2005 at 04:03:29PM -0800, Randy.Dunlap wrote:
>
>>(resend)
>>
>>Use C99 struct inits as requested by sparse:
>>fs/proc/base.c:738:2: warning: obsolete struct initializer, use C99 syntax
>>fs/proc/base.c:739:2: warning: obsolete struct initializer, use C99 syntax
>
>
> I posted a patch for this, and an included `__user` missing
> from the self-same set of functions a short while ago.
Sounds better. I hadn't noticed that part...
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-15 0:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-15 0:03 [PATCH] procfs: convert to C99 inits Randy.Dunlap
2005-03-15 0:15 ` Ben Dooks
2005-03-15 0:19 ` Randy.Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.