* [PATCH] mtd: use unsigned 1-bit fields
@ 2005-03-15 0:07 Randy.Dunlap
2005-03-15 0:14 ` Ben Dooks
0 siblings, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2005-03-15 0:07 UTC (permalink / raw)
To: dwmw2, akpm; +Cc: lkml
(resend)
Fix (22) bitfield/boolean sparse warnings:
include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield
include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
include/linux/mtd/flashchip.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Naurp ./include/linux/mtd/flashchip.h~mtd_flashchip_bool ./include/linux/mtd/flashchip.h
--- ./include/linux/mtd/flashchip.h~mtd_flashchip_bool 2005-02-15 13:48:46.633263712 -0800
+++ ./include/linux/mtd/flashchip.h 2005-02-15 20:25:20.924981544 -0800
@@ -62,8 +62,8 @@ struct flchip {
flstate_t state;
flstate_t oldstate;
- int write_suspended:1;
- int erase_suspended:1;
+ unsigned int write_suspended:1;
+ unsigned int erase_suspended:1;
unsigned long in_progress_block_addr;
spinlock_t *mutex;
---
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: use unsigned 1-bit fields
2005-03-15 0:07 [PATCH] mtd: use unsigned 1-bit fields Randy.Dunlap
@ 2005-03-15 0:14 ` Ben Dooks
2005-03-15 0:26 ` Randy.Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Ben Dooks @ 2005-03-15 0:14 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: dwmw2, akpm, lkml
On Mon, Mar 14, 2005 at 04:07:01PM -0800, Randy.Dunlap wrote:
> (resend)
>
> Fix (22) bitfield/boolean sparse warnings:
> include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield
> include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield
caught in the mtd-cvs, so it depends if you want to
wait for the next mtd merge or not.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: use unsigned 1-bit fields
2005-03-15 0:14 ` Ben Dooks
@ 2005-03-15 0:26 ` Randy.Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy.Dunlap @ 2005-03-15 0:26 UTC (permalink / raw)
To: Ben Dooks; +Cc: dwmw2, akpm, lkml
Ben Dooks wrote:
> On Mon, Mar 14, 2005 at 04:07:01PM -0800, Randy.Dunlap wrote:
>
>>(resend)
>>
>>Fix (22) bitfield/boolean sparse warnings:
>>include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield
>>include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield
>
>
> caught in the mtd-cvs, so it depends if you want to
> wait for the next mtd merge or not.
That's fine by me. I didn't know it had made it to the mtd-cvs.
Thanks for the message.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] MTD: use unsigned 1-bit fields
@ 2005-02-17 0:06 Randy.Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy.Dunlap @ 2005-02-17 0:06 UTC (permalink / raw)
To: linux-mtd; +Cc: dwmw2
since a 1-bit field cannot hold a truth value and a sign bit.
Fix (22) bitfield/boolean sparse warnings:
include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield
include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
include/linux/mtd/flashchip.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Naurp ./include/linux/mtd/flashchip.h~mtd_flashchip_bool ./include/linux/mtd/flashchip.h
--- ./include/linux/mtd/flashchip.h~mtd_flashchip_bool 2005-02-15 13:48:46.633263712 -0800
+++ ./include/linux/mtd/flashchip.h 2005-02-15 20:25:20.924981544 -0800
@@ -62,8 +62,8 @@ struct flchip {
flstate_t state;
flstate_t oldstate;
- int write_suspended:1;
- int erase_suspended:1;
+ unsigned int write_suspended:1;
+ unsigned int erase_suspended:1;
unsigned long in_progress_block_addr;
spinlock_t *mutex;
---
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-03-15 0:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-15 0:07 [PATCH] mtd: use unsigned 1-bit fields Randy.Dunlap
2005-03-15 0:14 ` Ben Dooks
2005-03-15 0:26 ` Randy.Dunlap
-- strict thread matches above, loose matches on Subject: below --
2005-02-17 0:06 [PATCH] MTD: " Randy.Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.