From: Anthony Liguori <aliguori@us.ibm.com>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: xen-devel <xen-devel@lists.sourceforge.net>
Subject: Re: [PATCH] tool xfrd x86-64 compilation fix.
Date: Tue, 22 Mar 2005 13:05:36 -0600 [thread overview]
Message-ID: <42406C80.3060202@us.ibm.com> (raw)
In-Reply-To: <1111517674.2106.8.camel@thinkpad>
size_t seems like the right type here. Probably should be:
fwrite(data, buf_n, 1, stdout);
printf("\n");
Regards,
Anthony Liguori
Jerone Young wrote:
>Fix curldebug function in xendomain.c of xfrd. Function takes argument
>"size_t buf_num" and uses it as the field width to print, that has to be
>an int. While size_t on 32 bit systems is 4bytes (or size of an int) it
>is 8bytes on 64bit systems (not size of an int). So this function should
>just use "int buf_num". This function is not used in the code anywhere.
>This will fix compilation on x86-64.
>
>Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
>--- tools/xfrd/xen_domain.c.orig 2005-03-22 12:52:04.156581136 -0600
>+++ tools/xfrd/xen_domain.c 2005-03-22 12:52:23.369660304 -0600
>@@ -176,7 +176,7 @@ static CURL *curlinit(void){
>
> /** Curl debug function.
> */
>-int curldebug(CURL *curl, curl_infotype ty, char *buf, size_t buf_n,
>void *data){
>+int curldebug(CURL *curl, curl_infotype ty, char *buf, int buf_n, void
>*data){
> printf("%*s\n", buf_n, buf);
> return 0;
> }
>
>
>
>
-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click
prev parent reply other threads:[~2005-03-22 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 18:54 [PATCH] tool xfrd x86-64 compilation fix Jerone Young
2005-03-22 19:05 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42406C80.3060202@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=jyoung5@us.ibm.com \
--cc=xen-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.