All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Nick Wilson <njw@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
	Linus Torvalds <torvalds@osdl.org>,
	linux-ide@vger.kernel.org, kernel-janitors@lists.osdl.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [KJ] Re: [PATCH] drivers/scsi/sata_svw.c: fix compiler warnings
Date: Tue, 05 Apr 2005 23:56:10 +0000	[thread overview]
Message-ID: <4253259A.4020304@pobox.com> (raw)
In-Reply-To: <20050405234001.GA10931@njw.pdx.osdl.net>

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

Nick Wilson wrote:
> Fixes compiler warnings:
>   warning: passing arg 2 of `writeb' makes pointer from integer without a cast
>   warning: passing arg 1 of `readw' makes pointer from integer without a cast

(added to CC list, just to update people on the status of these 
warnings...  I know they're annoying)

Thanks, but like I told someone else just yesterday, I'm not interested 
in patches which simply shift the warnings around.

You need something _far_ more substantial, like what I have attached, 
which updates libata to use the iomap infrastructure.

The warnings are there to let me (and others) know where the changes 
need to be made.  Applying a patch like yours will almost guarantee that 
I will miss a spot that needs to be converted.

Attachments:
patch.1:  97% of the iomap conversion.
patch.2:  add kernel infrastructure to map, and store, a bunch of PCI 
BARs.  For many IDE controllers, one must map 5-6 PCI BARs, but for 
others, everything is aggregated into a single MMIO PCI BAR.

The remaining task is to marry the two attached patches, and the work is 
complete.

	Jeff



[-- Attachment #2: patch.1.bz2 --]
[-- Type: application/x-bzip2, Size: 9040 bytes --]

[-- Attachment #3: patch.2.bz2 --]
[-- Type: application/x-bzip2, Size: 5827 bytes --]

[-- Attachment #4: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Nick Wilson <njw@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
	Linus Torvalds <torvalds@osdl.org>,
	linux-ide@vger.kernel.org, kernel-janitors@lists.osdl.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [KJ] Re: [PATCH] drivers/scsi/sata_svw.c: fix compiler warnings
Date: Tue, 05 Apr 2005 19:56:10 -0400	[thread overview]
Message-ID: <4253259A.4020304@pobox.com> (raw)
In-Reply-To: <20050405234001.GA10931@njw.pdx.osdl.net>

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

Nick Wilson wrote:
> Fixes compiler warnings:
>   warning: passing arg 2 of `writeb' makes pointer from integer without a cast
>   warning: passing arg 1 of `readw' makes pointer from integer without a cast

(added to CC list, just to update people on the status of these 
warnings...  I know they're annoying)

Thanks, but like I told someone else just yesterday, I'm not interested 
in patches which simply shift the warnings around.

You need something _far_ more substantial, like what I have attached, 
which updates libata to use the iomap infrastructure.

The warnings are there to let me (and others) know where the changes 
need to be made.  Applying a patch like yours will almost guarantee that 
I will miss a spot that needs to be converted.

Attachments:
patch.1:  97% of the iomap conversion.
patch.2:  add kernel infrastructure to map, and store, a bunch of PCI 
BARs.  For many IDE controllers, one must map 5-6 PCI BARs, but for 
others, everything is aggregated into a single MMIO PCI BAR.

The remaining task is to marry the two attached patches, and the work is 
complete.

	Jeff



[-- Attachment #2: patch.1.bz2 --]
[-- Type: application/x-bzip2, Size: 9040 bytes --]

[-- Attachment #3: patch.2.bz2 --]
[-- Type: application/x-bzip2, Size: 5827 bytes --]

[-- Attachment #4: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Nick Wilson <njw@osdl.org>
Cc: kernel-janitors@lists.osdl.org, linux-ide@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Subject: Re: [PATCH] drivers/scsi/sata_svw.c: fix compiler warnings
Date: Tue, 05 Apr 2005 19:56:10 -0400	[thread overview]
Message-ID: <4253259A.4020304@pobox.com> (raw)
In-Reply-To: <20050405234001.GA10931@njw.pdx.osdl.net>

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

Nick Wilson wrote:
> Fixes compiler warnings:
>   warning: passing arg 2 of `writeb' makes pointer from integer without a cast
>   warning: passing arg 1 of `readw' makes pointer from integer without a cast

(added to CC list, just to update people on the status of these 
warnings...  I know they're annoying)

Thanks, but like I told someone else just yesterday, I'm not interested 
in patches which simply shift the warnings around.

You need something _far_ more substantial, like what I have attached, 
which updates libata to use the iomap infrastructure.

The warnings are there to let me (and others) know where the changes 
need to be made.  Applying a patch like yours will almost guarantee that 
I will miss a spot that needs to be converted.

Attachments:
patch.1:  97% of the iomap conversion.
patch.2:  add kernel infrastructure to map, and store, a bunch of PCI 
BARs.  For many IDE controllers, one must map 5-6 PCI BARs, but for 
others, everything is aggregated into a single MMIO PCI BAR.

The remaining task is to marry the two attached patches, and the work is 
complete.

	Jeff



[-- Attachment #2: patch.1.bz2 --]
[-- Type: application/x-bzip2, Size: 9040 bytes --]

[-- Attachment #3: patch.2.bz2 --]
[-- Type: application/x-bzip2, Size: 5827 bytes --]

  reply	other threads:[~2005-04-05 23:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-05 23:40 [KJ] [PATCH] drivers/scsi/sata_svw.c: fix compiler warnings Nick Wilson
2005-04-05 23:40 ` Nick Wilson
2005-04-05 23:56 ` Jeff Garzik [this message]
2005-04-05 23:56   ` Jeff Garzik
2005-04-05 23:56   ` [KJ] " Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4253259A.4020304@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=njw@osdl.org \
    --cc=torvalds@osdl.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.