From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Farouk Bouabid <farouk.bouabid@cherry.de>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Peter Rosin <peda@axentia.se>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Heiko Stuebner <heiko@sntech.de>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v6 2/8] i2c: muxes: add support for tsd,mule-i2c multiplexer
Date: Mon, 12 Aug 2024 15:13:11 +0200 [thread overview]
Message-ID: <426eb8b6-9b2f-4594-9cc3-320ef0cee835@kernel.org> (raw)
In-Reply-To: <Zrn-ZkgYKVquarDX@ninjato>
On 12/08/2024 14:21, Wolfram Sang wrote:
>
>> Yep, but to be fair the patchset did not say anything about
>> dependencies. There is absolutely nothing in cover letter, nothing in
>> the patches, so I do not wonder that this mishap happened.
>
> Still, one shouldn't take DT patches (which are even the last ones in
> this series) until all other patches are at least in -next, or? Yes,
> mistakes happen, so no big deal, but i2c is not to blame IMHO.
No, it's not. It was just a ping. The issue is here not describing
dependency, allowing Guenter to take the patch and not even telling him
that now next has warning. :/ It's like entire weight is on maintainers
and contributors care only about getting their patch inside. Once it is
inside, not my problem anymore... :(
>
>> Depends whether you rely on being CC-ed here. Existing entries do not
>
> I don't rely on CC. I rely on patches being on the i2c list.
>
>> include you, thus you are not cc-ed on maintainers. Peter Rosin is, but
>> it seems Peter does not apply patches. It could be intentional, but then
>> I understand that all pings should go to Peter?
>
> Once Peter acks, I apply. He is the maintainer. Yet, he is very busy, so
> I also apply when someone else I trust does a review. He is fine with
Sure, that explains, so ping should not really go to you...
> that and might chime in later, if needed. This patch here did not get
> any review, sadly. As I said, resource problem. That being said, these
> patches are somewhere on my todo list if nobody else steps up (what I
> would prefer). But please, don't put pressure on me (or any other
> potential reviewer) just because DT patches ended up upstream too early.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Farouk Bouabid <farouk.bouabid@cherry.de>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Peter Rosin <peda@axentia.se>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Heiko Stuebner <heiko@sntech.de>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v6 2/8] i2c: muxes: add support for tsd,mule-i2c multiplexer
Date: Mon, 12 Aug 2024 15:13:11 +0200 [thread overview]
Message-ID: <426eb8b6-9b2f-4594-9cc3-320ef0cee835@kernel.org> (raw)
In-Reply-To: <Zrn-ZkgYKVquarDX@ninjato>
On 12/08/2024 14:21, Wolfram Sang wrote:
>
>> Yep, but to be fair the patchset did not say anything about
>> dependencies. There is absolutely nothing in cover letter, nothing in
>> the patches, so I do not wonder that this mishap happened.
>
> Still, one shouldn't take DT patches (which are even the last ones in
> this series) until all other patches are at least in -next, or? Yes,
> mistakes happen, so no big deal, but i2c is not to blame IMHO.
No, it's not. It was just a ping. The issue is here not describing
dependency, allowing Guenter to take the patch and not even telling him
that now next has warning. :/ It's like entire weight is on maintainers
and contributors care only about getting their patch inside. Once it is
inside, not my problem anymore... :(
>
>> Depends whether you rely on being CC-ed here. Existing entries do not
>
> I don't rely on CC. I rely on patches being on the i2c list.
>
>> include you, thus you are not cc-ed on maintainers. Peter Rosin is, but
>> it seems Peter does not apply patches. It could be intentional, but then
>> I understand that all pings should go to Peter?
>
> Once Peter acks, I apply. He is the maintainer. Yet, he is very busy, so
> I also apply when someone else I trust does a review. He is fine with
Sure, that explains, so ping should not really go to you...
> that and might chime in later, if needed. This patch here did not get
> any review, sadly. As I said, resource problem. That being said, these
> patches are somewhere on my todo list if nobody else steps up (what I
> would prefer). But please, don't put pressure on me (or any other
> potential reviewer) just because DT patches ended up upstream too early.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-08-12 13:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 13:27 [PATCH v6 0/8] Add tsd,mule-i2c-mux support Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
2024-07-25 13:27 ` [PATCH v6 1/8] dt-bindings: i2c: add support for tsd,mule-i2c-mux Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
2024-08-31 21:05 ` Wolfram Sang
2024-08-31 21:05 ` Wolfram Sang
2024-07-25 13:27 ` [PATCH v6 2/8] i2c: muxes: add support for tsd,mule-i2c multiplexer Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
2024-08-12 9:24 ` Quentin Schulz
2024-08-12 9:24 ` Quentin Schulz
2024-08-12 9:29 ` Krzysztof Kozlowski
2024-08-12 9:29 ` Krzysztof Kozlowski
2024-08-12 10:06 ` Wolfram Sang
2024-08-12 10:06 ` Wolfram Sang
2024-08-12 11:37 ` Krzysztof Kozlowski
2024-08-12 11:37 ` Krzysztof Kozlowski
2024-08-12 12:21 ` Wolfram Sang
2024-08-12 12:21 ` Wolfram Sang
2024-08-12 13:13 ` Krzysztof Kozlowski [this message]
2024-08-12 13:13 ` Krzysztof Kozlowski
2024-08-12 13:28 ` Guenter Roeck
2024-08-12 13:28 ` Guenter Roeck
2024-08-12 17:37 ` Wolfram Sang
2024-08-12 17:37 ` Wolfram Sang
2024-08-31 20:57 ` Wolfram Sang
2024-08-31 20:57 ` Wolfram Sang
2024-07-25 13:27 ` [PATCH v6 3/8] dt-bindings: hwmon: add support for ti,amc6821 Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
2024-07-30 16:10 ` Rob Herring (Arm)
2024-07-30 16:10 ` Rob Herring (Arm)
2024-07-31 15:11 ` Guenter Roeck
2024-07-31 15:11 ` Guenter Roeck
2024-07-25 13:27 ` [PATCH v6 4/8] hwmon: (amc6821) add support for tsd,mule Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
2024-07-25 14:02 ` Guenter Roeck
2024-07-25 14:02 ` Guenter Roeck
2024-07-31 15:12 ` Guenter Roeck
2024-07-31 15:12 ` Guenter Roeck
2024-08-12 11:38 ` Krzysztof Kozlowski
2024-08-12 11:38 ` Krzysztof Kozlowski
2024-08-12 11:58 ` Quentin Schulz
2024-08-12 11:58 ` Quentin Schulz
2024-08-12 13:10 ` Krzysztof Kozlowski
2024-08-12 13:10 ` Krzysztof Kozlowski
2024-08-12 13:21 ` Guenter Roeck
2024-08-12 13:21 ` Guenter Roeck
2024-08-12 13:24 ` Krzysztof Kozlowski
2024-08-12 13:24 ` Krzysztof Kozlowski
2024-07-25 13:27 ` [PATCH v6 5/8] arm64: dts: rockchip: add tsd,mule-i2c-mux on rk3588-jaguar Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
2024-07-25 13:27 ` [PATCH v6 6/8] arm64: dts: rockchip: add tsd,mule-i2c-mux on rk3399-puma Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
2024-07-25 13:27 ` [PATCH v6 7/8] arm64: dts: rockchip: add tsd,mule-i2c-mux on rk3588-tiger Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
2024-07-25 13:27 ` [PATCH v6 8/8] arm64: dts: rockchip: add tsd,mule-i2c-mux on px30-ringneck Farouk Bouabid
2024-07-25 13:27 ` Farouk Bouabid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426eb8b6-9b2f-4594-9cc3-320ef0cee835@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=farouk.bouabid@cherry.de \
--cc=heiko@sntech.de \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=peda@axentia.se \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.