From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 6.1.y 1/5] erofs: get rid of erofs_inode_datablocks()
Date: Tue, 8 Oct 2024 19:03:06 +0800 [thread overview]
Message-ID: <4276433b-976e-4e27-9568-ab02e6759905@linux.alibaba.com> (raw)
In-Reply-To: <2024100829-unplowed-vending-675b@gregkh>
On 2024/10/8 18:26, Greg Kroah-Hartman wrote:
> On Tue, Oct 08, 2024 at 02:57:04PM +0800, Gao Xiang wrote:
>> commit 4efdec36dc9907628e590a68193d6d8e5e74d032 upstream.
>>
>> erofs_inode_datablocks() has the only one caller, let's just get
>> rid of it entirely. No logic changes.
>>
>> Reviewed-by: Yue Hu <huyue2@coolpad.com>
>> Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
>> Reviewed-by: Chao Yu <chao@kernel.org>
>> Stable-dep-of: 9ed50b8231e3 ("erofs: fix incorrect symlink detection in fast symlink")
>> Link: https://lore.kernel.org/r/20230204093040.97967-1-hsiangkao@linux.alibaba.com
>> [ Gao Xiang: apply this to 6.6.y to avoid further backport twists
>> due to obsoleted EROFS_BLKSIZ. ]
>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>> ---
>> Obsoleted EROFS_BLKSIZ impedes efforts to backport
>> 9ed50b8231e3 ("erofs: fix incorrect symlink detection in fast symlink")
>> 9e2f9d34dd12 ("erofs: handle overlapped pclusters out of crafted images properly")
>>
>> To avoid further bugfix conflicts due to random EROFS_BLKSIZs
>> around the whole codebase, just backport the dependencies for 6.1.y.
>
> all now queued up, thanks.
Thanks Greg, I'd like to avoid obsoleted EROFS_BLKSIZ
conflicts for 6.1.y anymore (and just a few dependencies
to avoid this), so that will save the future bugfix
backport efforts around the 6.1.y codebase.
For more older stable versions, I will manually handle
conflicts later since more non-trivial dependencies need
otherwise but I think bugfixes for older stable versions
will become fewer and fewer...
Thanks,
Gao Xiang
>
> greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-erofs@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6.1.y 1/5] erofs: get rid of erofs_inode_datablocks()
Date: Tue, 8 Oct 2024 19:03:06 +0800 [thread overview]
Message-ID: <4276433b-976e-4e27-9568-ab02e6759905@linux.alibaba.com> (raw)
In-Reply-To: <2024100829-unplowed-vending-675b@gregkh>
On 2024/10/8 18:26, Greg Kroah-Hartman wrote:
> On Tue, Oct 08, 2024 at 02:57:04PM +0800, Gao Xiang wrote:
>> commit 4efdec36dc9907628e590a68193d6d8e5e74d032 upstream.
>>
>> erofs_inode_datablocks() has the only one caller, let's just get
>> rid of it entirely. No logic changes.
>>
>> Reviewed-by: Yue Hu <huyue2@coolpad.com>
>> Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
>> Reviewed-by: Chao Yu <chao@kernel.org>
>> Stable-dep-of: 9ed50b8231e3 ("erofs: fix incorrect symlink detection in fast symlink")
>> Link: https://lore.kernel.org/r/20230204093040.97967-1-hsiangkao@linux.alibaba.com
>> [ Gao Xiang: apply this to 6.6.y to avoid further backport twists
>> due to obsoleted EROFS_BLKSIZ. ]
>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>> ---
>> Obsoleted EROFS_BLKSIZ impedes efforts to backport
>> 9ed50b8231e3 ("erofs: fix incorrect symlink detection in fast symlink")
>> 9e2f9d34dd12 ("erofs: handle overlapped pclusters out of crafted images properly")
>>
>> To avoid further bugfix conflicts due to random EROFS_BLKSIZs
>> around the whole codebase, just backport the dependencies for 6.1.y.
>
> all now queued up, thanks.
Thanks Greg, I'd like to avoid obsoleted EROFS_BLKSIZ
conflicts for 6.1.y anymore (and just a few dependencies
to avoid this), so that will save the future bugfix
backport efforts around the 6.1.y codebase.
For more older stable versions, I will manually handle
conflicts later since more non-trivial dependencies need
otherwise but I think bugfixes for older stable versions
will become fewer and fewer...
Thanks,
Gao Xiang
>
> greg k-h
next prev parent reply other threads:[~2024-10-08 11:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 6:57 [PATCH 6.1.y 1/5] erofs: get rid of erofs_inode_datablocks() Gao Xiang
2024-10-08 6:57 ` [PATCH 6.1.y 2/5] erofs: get rid of z_erofs_do_map_blocks() forward declaration Gao Xiang
2024-10-08 10:27 ` Patch "erofs: get rid of z_erofs_do_map_blocks() forward declaration" has been added to the 6.1-stable tree gregkh
2024-10-08 6:57 ` [PATCH 6.1.y 3/5] erofs: avoid hardcoded blocksize for subpage block support Gao Xiang
2024-10-08 10:27 ` Patch "erofs: avoid hardcoded blocksize for subpage block support" has been added to the 6.1-stable tree gregkh
2024-10-08 6:57 ` [PATCH 6.1.y 4/5] erofs: set block size to the on-disk block size Gao Xiang
2024-10-08 10:27 ` Patch "erofs: set block size to the on-disk block size" has been added to the 6.1-stable tree gregkh
2024-10-08 6:57 ` [PATCH 6.1.y 5/5] erofs: fix incorrect symlink detection in fast symlink Gao Xiang
2024-10-08 10:27 ` Patch "erofs: fix incorrect symlink detection in fast symlink" has been added to the 6.1-stable tree gregkh
2024-10-08 10:26 ` [PATCH 6.1.y 1/5] erofs: get rid of erofs_inode_datablocks() Greg Kroah-Hartman
2024-10-08 10:26 ` Greg Kroah-Hartman
2024-10-08 11:03 ` Gao Xiang [this message]
2024-10-08 11:03 ` Gao Xiang
2024-10-08 10:27 ` Patch "erofs: get rid of erofs_inode_datablocks()" has been added to the 6.1-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4276433b-976e-4e27-9568-ab02e6759905@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.