* [NETFILTER]: Don't checksum CHECKSUM_UNNECESSARY skbs in TCP connection tracking
@ 2005-05-03 16:53 Patrick McHardy
2005-05-03 21:23 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2005-05-03 16:53 UTC (permalink / raw)
To: David S. Miller; +Cc: Netfilter Development Mailinglist
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
TCP connection tracking incorrectly tries to verify the checksum of
CHECKSUM_UNNECESSARY packets. This causes packets on loopback to
be tracked as INVALID since we now drop the conntrack reference on
output and don't skip connection tracking on input anymore.
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1163 bytes --]
[NETFILTER]: Don't checksum CHECKSUM_UNNECESSARY skbs in TCP connection tracking
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit 28b4b5756c08e6c4f053e6298c6cc176dd51cc9c
tree 37a577077717c6fc76b74317dd95502e3c0b0803
parent 480fc9b2802f2093e728567010506732e382b688
author Patrick McHardy <kaber@trash.net> 1115138945 +0200
committer Patrick McHardy <kaber@trash.net> 1115138945 +0200
Index: net/ipv4/netfilter/ip_conntrack_proto_tcp.c
===================================================================
--- 97b316503a4524074c05d5fb4cab63264690d0d6/net/ipv4/netfilter/ip_conntrack_proto_tcp.c (mode:100644 sha1:2b87c1974be605d5bdb1ee769188d7e03fb2ddc8)
+++ 37a577077717c6fc76b74317dd95502e3c0b0803/net/ipv4/netfilter/ip_conntrack_proto_tcp.c (mode:100644 sha1:721ddbf522b422d554479a7ab15c0955798f16ee)
@@ -819,6 +819,7 @@
*/
/* FIXME: Source route IP option packets --RR */
if (hooknum == NF_IP_PRE_ROUTING
+ && skb->ip_summed != CHECKSUM_UNNECESSARY
&& csum_tcpudp_magic(iph->saddr, iph->daddr, tcplen, IPPROTO_TCP,
skb->ip_summed == CHECKSUM_HW ? skb->csum
: skb_checksum(skb, iph->ihl*4, tcplen, 0))) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [NETFILTER]: Don't checksum CHECKSUM_UNNECESSARY skbs in TCP connection tracking
2005-05-03 16:53 [NETFILTER]: Don't checksum CHECKSUM_UNNECESSARY skbs in TCP connection tracking Patrick McHardy
@ 2005-05-03 21:23 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-05-03 21:23 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netfilter-devel
On Tue, 03 May 2005 18:53:15 +0200
Patrick McHardy <kaber@trash.net> wrote:
> TCP connection tracking incorrectly tries to verify the checksum of
> CHECKSUM_UNNECESSARY packets. This causes packets on loopback to
> be tracked as INVALID since we now drop the conntrack reference on
> output and don't skip connection tracking on input anymore.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-03 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-03 16:53 [NETFILTER]: Don't checksum CHECKSUM_UNNECESSARY skbs in TCP connection tracking Patrick McHardy
2005-05-03 21:23 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.