Re: [lm-sensors] lmsensors doesn't detect core-i7 sensors

[Mahmood Naderan <nt_mahmood@yahoo.com>]

[-- Attachment #1.1: Type: text/plain, Size: 7384 bytes --]

>2) lm_sensors doesn't work with Ubuntu anyway, since /etc/init.d/functions
>  does not exist.

Agree with that. Another thing I found is that the default locations are 
different for "installing via synaptic" and "installing from source". See this 
log:

mahmood@lcoalhost:lm-sensors$sudo make install
mkdir -p /usr/local/lib /usr/local/include/sensors /usr/local/man/man3 
/usr/local/man/man5
******************************************************************************
Warning: This is the first installation of the libsensors.so.4*
         library files in /usr/local/lib!
         You must update the library cache or the userspace tools may fail
         or have unpredictable results!
         Run the following command: /sbin/ldconfig
******************************************************************************
install -m 644 lib/libsensors.a /usr/local/lib
install -m 755 lib/libsensors.so.4.2.1 /usr/local/lib
ln -sf libsensors.so.4.2.1 /usr/local/lib/libsensors.so.4
ln -sf libsensors.so.4 /usr/local/lib/libsensors.so
******************************************************************************
Warning: Library directory /usr/local/lib is not in /etc/ld.so.conf!
         Add it and run /sbin/ldconfig for the userspace tools to work.
******************************************************************************
install -m 644 lib/error.h lib/sensors.h /usr/local/include/sensors
install -m 644 lib/libsensors.3 /usr/local/man/man3
install -m 644 lib/sensors.conf.5 /usr/local/man/man5
ln -sf sensors.conf.5 /usr/local/man/man5/sensors3.conf.5
mkdir -p /usr/local/sbin /usr/local/man/man8
install -m 755 prog/detect/sensors-detect /usr/local/sbin
install -m 644 prog/detect/sensors-detect.8 /usr/local/man/man8
mkdir -p /usr/local/sbin /usr/local/man/man8
install -m 755 prog/pwm/fancontrol prog/pwm/pwmconfig /usr/local/sbin
install -m 644 prog/pwm/fancontrol.8 prog/pwm/pwmconfig.8 /usr/local/man/man8
mkdir -p /usr/local/bin /usr/local/man/man1
install -m 755 prog/sensors/sensors /usr/local/bin
install -m 644 prog/sensors/sensors.1 /usr/local/man/man1
mkdir -p /etc /etc/sensors.d
if [ ! -e /etc/sensors3.conf ] ; then \
          install -m 644 etc/sensors.conf.default /etc/sensors3.conf ; \
        fi
mkdir -p /usr/local/bin
install -m 755 etc/sensors-conf-convert /usr/local/bin
if [ -e /etc/modprobe.d/lm_sensors \
             -a ! -e /etc/modprobe.d/lm_sensors.conf ] ; then \
          mv -f /etc/modprobe.d/lm_sensors /etc/modprobe.d/lm_sensors.conf ; \
        fi
mkdir -p /usr/local/sbin /usr/local/man/man8
install -m 755 prog/dump/isadump prog/dump/isaset /usr/local/sbin
install -m 644 prog/dump/isadump.8 prog/dump/isaset.8 /usr/local/man/man8
*** Important notes:
***  * The libsensors configuration file (/etc/sensors3.conf) is never
***    overwritten by our installation process, so that you won't lose
***    your personal settings in that file. You still can get our latest
***    default config file in etc/sensors.conf.default and manually copy
***    it to /etc/sensors3.conf if you want. You will then want to
***    edit it to fit your needs again.
***  * The format of /etc/sensors3.conf changed with lm-sensors 3.0.0.
***    If you have a custom configuration file using the old format, you
***    can convert it using the sensors-conf-convert script. Otherwise just
***    overwrite your old configuration file with the new default one.
***  * As off lm-sensors 3.1.0, the default configuration file only
***    contains statements which do not depend on how chips are wired.
***    If you miss parts of the bigger configuration file that used to be
***    the default, copy the relevant parts from etc/sensors.conf.eg to
***    /etc/sensors3.conf.

 
// Naderan *Mahmood;




________________________________
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Mahmood Naderan <nt_mahmood@yahoo.com>; lm-sensors 
<lm-sensors@lm-sensors.org>
Sent: Sat, September 4, 2010 6:55:34 PM
Subject: Re: [lm-sensors] lmsensors doesn't detect core-i7 sensors

Jean,

On Sat, Sep 04, 2010 at 09:49:42AM -0400, Jean Delvare wrote:
> Guenter,
> 
> On Wed, 1 Sep 2010 07:32:25 -0700, Guenter Roeck wrote:
> > On Wed, Sep 01, 2010 at 09:56:01AM -0400, Jean Delvare wrote:
> > > On Wed, 1 Sep 2010 06:26:34 -0700, Guenter Roeck wrote:
> > > > On Wed, Sep 01, 2010 at 04:16:41AM -0400, Mahmood Naderan wrote:
> > > > > >sudo /etc/init.d/lm_sensors restart
> > > > > 
> > > > > mahmood@localhost:~$<mailto:mahmood@localhost:~$> sudo 
>/etc/init.d/lm-sensors restart
> > > > > .: 39: Can't open /etc/init.d/functions
> > > > > 
> > > > > Note there is no lm_sensors. I have lm-sensors
> > > > > 
> > > > 
> > > > I tried /etc/init.d/lm-sensors on a lucid (10.04) system and it works for 
>me. It looks like
> > > > you overwrote the original version of /etc/init.d/lm-sensors with 
>prog/init.d/lm_sensors.
> > > > That won't work - prog/init.d/lm_sensors does not work with lucid. You'll 
>need to reinstall
> > > > the original version of /etc/init.d/lm-sensors and try again.
> > > 
> > > I proposed once to delete these initialization scripts from our
> > > repository as they are quite distribution specific, but the few votes
> > > were not in my favor.
> > > 
> > How about some kind of warning, or at least use different wording in 
>sensors-detect ?
> > 
> > The current text is quite absolute ("Copy prog/init/lm_sensors.init to 
>/etc/init.d/lm_sensors")
> > and really invites users to overwrite the distribution specific scripts.
> 
> Actually it doesn't:
> 
>         print "Copy prog/init/lm_sensors.init to /etc/init.d/lm_sensors\n".
>               "for initialization at boot time.\n"
>             unless -f "/etc/init.d/lm_sensors";
> 
> So the message isn't printed if there is already a script there.
> 
> In Mahmood's case, the script is named /etc/init.d/lm-sensors instead,
> so the message would be printed, but running the suggested command
> would _not_ overwrite the file. Not sure what happens where both
> scripts are present though...
> 
Problem is two-fold: 
1) People will/may remove lm-sensors anyway, being intelligent and assuming
  this is what they should do.
2) lm_sensors doesn't work with Ubuntu anyway, since /etc/init.d/functions
  does not exist.

> So I would suggest that we simply extend the test to:
> 
>             unless -f "/etc/init.d/lm_sensors"
>                 or -f "/etc/init.d/lm-sensors";
> 
> Would that be OK with you?
> 
Yes.

Another question is if we can get rid of the inclusion of /etc/init.d/functions.
I browsed through the code, but don't immediately see which functions
are used from it, and if they can be replaced. What do you think ?

> If you have a better proposal, I'm listening. The only alternative I
> have in mind is to get rid of the message altogether and delete the
> init script from our repository, leaving integration up to each
> distribution (which at least openSUSE and derivatives already do.)
> 
Removing it sounds like overkill to me. After all, it _does_
provide value (when it works). Maybe we should do the above,
and spend some time getting it to work w/ Ubuntu given its
distribution. I should be able to do that.

Thanks,
Guenter



      

[-- Attachment #1.2: Type: text/html, Size: 9925 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors