From: Hollis Blanchard <hollisb@us.ibm.com>
To: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@hp.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: recent major -unstable changes cause ia64 build to be broken
Date: Tue, 10 May 2005 16:35:24 -0500 [thread overview]
Message-ID: <4281291C.8090305@us.ibm.com> (raw)
In-Reply-To: <516F50407E01324991DD6D07B0531AD542CA2F@cacexc12.americas.cpqcorp.net>
Magenheimer, Dan (HP Labs Fort Collins) wrote:
>
> The biggest problem was due to the removal of three
> includes from include/xen/slab.h... this was obscured
> by some of the other changes.
>
> Could you put these back in where they were before please?
> (If necessary, with a ifdef ia64 for now and we can sort
> it out later.)
>
> < #include <xen/mm.h>
> < #include <xen/cache.h>
> < #include <xen/types.h>
>
> Actually, it appears I only need xen/mm.h if that helps.
I needed to include xen/mm.h in a handful of (common) places with the
new code:
xen/common/page_alloc.c
xen/common/schedule.c
xen/drivers/char/console.c
These files all use things from xen/mm.h, but do not include it. Here I
will repeat my point about relying on implicit includes... :)
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2005-05-10 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 21:29 recent major -unstable changes cause ia64 build to be broken Magenheimer, Dan (HP Labs Fort Collins)
2005-05-10 21:35 ` Hollis Blanchard [this message]
2005-05-10 21:42 ` Christian Limpach
-- strict thread matches above, loose matches on Subject: below --
2005-05-10 23:20 Magenheimer, Dan (HP Labs Fort Collins)
2005-05-10 23:08 Magenheimer, Dan (HP Labs Fort Collins)
2005-05-10 23:05 Magenheimer, Dan (HP Labs Fort Collins)
2005-05-11 15:04 ` Hollis Blanchard
2005-05-10 22:50 Magenheimer, Dan (HP Labs Fort Collins)
2005-05-10 23:14 ` Christian Limpach
2005-05-10 22:16 Magenheimer, Dan (HP Labs Fort Collins)
2005-05-10 22:10 Magenheimer, Dan (HP Labs Fort Collins)
2005-05-10 22:30 ` Christian Limpach
2005-05-10 21:43 Magenheimer, Dan (HP Labs Fort Collins)
2005-05-10 19:16 Magenheimer, Dan (HP Labs Fort Collins)
2005-05-10 20:17 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4281291C.8090305@us.ibm.com \
--to=hollisb@us.ibm.com \
--cc=dan.magenheimer@hp.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.