All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: akpm@osdl.org, T-Bone@parisc-linux.org, varenet@parisc-linux.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Netdev <netdev@oss.sgi.com>
Subject: Re: patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree
Date: Mon, 16 May 2005 12:46:09 -0400	[thread overview]
Message-ID: <4288CE51.1050703@pobox.com> (raw)
In-Reply-To: <20050516050843.GA20107@colo.lackof.org>

Simply ensure that tulip_select_media() is always called from a process 
context. Then can you delay all you want.  Several of the calls are 
already this way, so that leaves two cases:

1) called from timer context, from the media poll timer

2) called from spin_lock_irqsave() context, in the ->tx_timeout hook.

The first case can be fixed by moved all the timer code to a workqueue. 
  Then when the existing timer fires, kick the workqueue.

The second case can be fixed by kicking the workqueue upon tx_timeout 
(which is the reason why I did not suggest queue_delayed_work() use).

See, it's not rocket science :)

	Jeff




  reply	other threads:[~2005-05-16 16:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200505101955.j4AJtX9x032464@shell0.pdx.osdl.net>
2005-05-16  4:06 ` patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree Jeff Garzik
2005-05-16  5:08   ` Grant Grundler
2005-05-16 16:46     ` Jeff Garzik [this message]
2005-05-16 22:26       ` Grant Grundler
2005-05-20 18:58         ` Jeff Garzik
2005-05-20 19:15           ` Francois Romieu
2005-05-20 21:12           ` Grant Grundler
2005-05-20 21:34             ` Jeff Garzik
2005-05-21  0:51               ` Grant Grundler
2005-05-21 22:39       ` Francois Romieu
2005-05-22  4:56         ` Grant Grundler
2005-05-27  2:16         ` Jeff Garzik
2005-05-27  7:17           ` Francois Romieu
2005-10-04 13:18             ` Jeff Garzik
2005-10-04 13:18             ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4288CE51.1050703@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=T-Bone@parisc-linux.org \
    --cc=akpm@osdl.org \
    --cc=grundler@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=varenet@parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.