EXPORT_SYMBOL(hash_conntrack)

EXPORT_SYMBOL(hash_conntrack)

[Damon Gray]

I have a need to be able to use hash_conntrack in a kernel module. Does 
anyone see a problem if hash_conntrack was exported? I'd prefer to use the 
function instead of duplicating it with jhash_3words just so I don't have 
to keep track of how hash_conntrack does the hashing.

Thanks

-Damon-

Re: EXPORT_SYMBOL(hash_conntrack)

[Pablo Neira]

Damon Gray wrote:
> I have a need to be able to use hash_conntrack in a kernel module. Does 
> anyone see a problem if hash_conntrack was exported? I'd prefer to use 
> the function instead of duplicating it with jhash_3words just so I don't 
> have to keep track of how hash_conntrack does the hashing.

Well, all the current exported symbols are used by other modules in 
kernel mainline and pom-ng. So you'll have to justify such exportation 
with some kind of candidate client (maybe your module) that could be 
useful for everyone.

--
Pablo

Re: EXPORT_SYMBOL(hash_conntrack)

[Damon Gray]

Understood, would it be more appropriate to change it to a static inline 
in ip_conntrack_core.h? It seems like a good candidate for inlining 
anyways.

Thanks

-Damon-

On Thu, 19 May 2005, Pablo Neira wrote:

> Damon Gray wrote:
>> I have a need to be able to use hash_conntrack in a kernel module. Does 
>> anyone see a problem if hash_conntrack was exported? I'd prefer to use the 
>> function instead of duplicating it with jhash_3words just so I don't have 
>> to keep track of how hash_conntrack does the hashing.
>
> Well, all the current exported symbols are used by other modules in kernel 
> mainline and pom-ng. So you'll have to justify such exportation with some 
> kind of candidate client (maybe your module) that could be useful for 
> everyone.
>
> --
> Pablo
>
>

Re: EXPORT_SYMBOL(hash_conntrack)

[Damon Gray]

Nevermind, hash_conntrack uses the static ip_conntrack_hash_rnd.

-Damon-

On Fri, 20 May 2005, Damon Gray wrote:

>
> Understood, would it be more appropriate to change it to a static inline in 
> ip_conntrack_core.h? It seems like a good candidate for inlining anyways.
>
> Thanks
>
> -Damon-
>
> On Thu, 19 May 2005, Pablo Neira wrote:
>
>> Damon Gray wrote:
>>> I have a need to be able to use hash_conntrack in a kernel module. Does 
>>> anyone see a problem if hash_conntrack was exported? I'd prefer to use the 
>>> function instead of duplicating it with jhash_3words just so I don't have 
>>> to keep track of how hash_conntrack does the hashing.
>> 
>> Well, all the current exported symbols are used by other modules in kernel 
>> mainline and pom-ng. So you'll have to justify such exportation with some 
>> kind of candidate client (maybe your module) that could be useful for 
>> everyone.
>> 
>> --
>> Pablo
>> 
>> 
>
>
>