[PATCH 1/2] staging/nvec: Do not pass resource to mfd_add

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()
@ 2014-07-29 11:16 ` Thierry Reding
  0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2014-07-29 11:16 UTC (permalink / raw)
  To: Julian Andres Klode, Marc Dietrich, Greg Kroah-Hartman
  Cc: linux-tegra, devel, linux-kernel, ac100

From: Thierry Reding <treding@nvidia.com>

The mfd_add_devices() function takes a struct resource * as fifth
argument, but the nvec driver passes in a void __iomem *. The driver
gets away with it because none of the subdevices ever directly access
the registers.

Since subdevices never need to access the registers we can simply pass
NULL instead.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/staging/nvec/nvec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 0a5c84ad3f41..815065837ce7 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -893,7 +893,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	}
 
 	ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
-			      ARRAY_SIZE(nvec_devices), base, 0, NULL);
+			      ARRAY_SIZE(nvec_devices), NULL, 0, NULL);
 	if (ret)
 		dev_err(nvec->dev, "error adding subdevices\n");
 
-- 
2.0.2

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()
@ 2014-07-29 11:16 ` Thierry Reding
  0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2014-07-29 11:16 UTC (permalink / raw)
  To: Julian Andres Klode, Marc Dietrich, Greg Kroah-Hartman
  Cc: ac100, linux-tegra, devel, linux-kernel

From: Thierry Reding <treding@nvidia.com>

The mfd_add_devices() function takes a struct resource * as fifth
argument, but the nvec driver passes in a void __iomem *. The driver
gets away with it because none of the subdevices ever directly access
the registers.

Since subdevices never need to access the registers we can simply pass
NULL instead.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/staging/nvec/nvec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 0a5c84ad3f41..815065837ce7 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -893,7 +893,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	}
 
 	ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
-			      ARRAY_SIZE(nvec_devices), base, 0, NULL);
+			      ARRAY_SIZE(nvec_devices), NULL, 0, NULL);
 	if (ret)
 		dev_err(nvec->dev, "error adding subdevices\n");
 
-- 
2.0.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] staging/nvec: Use platform_get_irq()
  2014-07-29 11:16 ` Thierry Reding
@ 2014-07-29 11:16   ` Thierry Reding
  -1 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2014-07-29 11:16 UTC (permalink / raw)
  To: Julian Andres Klode, Marc Dietrich, Greg Kroah-Hartman
  Cc: linux-tegra, devel, linux-kernel, ac100

From: Thierry Reding <treding@nvidia.com>

As opposed to platform_get_resource(), the platform_get_irq() function
has special code to handle driver probe deferral when booting using DT
and where an interrupt provider hasn't been registered yet. While this
is unlikely to become an issue for nvec, platform_get_irq() is the
recommended way to get at interrupts.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/staging/nvec/nvec.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 815065837ce7..a93208adbfcf 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -821,8 +821,8 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	if (IS_ERR(base))
 		return PTR_ERR(base);
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!res) {
+	nvec->irq = platform_get_irq(pdev, 0);
+	if (nvec->irq < 0) {
 		dev_err(&pdev->dev, "no irq resource?\n");
 		return -ENODEV;
 	}
@@ -840,7 +840,6 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	}
 
 	nvec->base = base;
-	nvec->irq = res->start;
 	nvec->i2c_clk = i2c_clk;
 	nvec->rx = &nvec->msg_pool[0];
 
-- 
2.0.2

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] staging/nvec: Use platform_get_irq()
@ 2014-07-29 11:16   ` Thierry Reding
  0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2014-07-29 11:16 UTC (permalink / raw)
  To: Julian Andres Klode, Marc Dietrich, Greg Kroah-Hartman
  Cc: ac100, linux-tegra, devel, linux-kernel

From: Thierry Reding <treding@nvidia.com>

As opposed to platform_get_resource(), the platform_get_irq() function
has special code to handle driver probe deferral when booting using DT
and where an interrupt provider hasn't been registered yet. While this
is unlikely to become an issue for nvec, platform_get_irq() is the
recommended way to get at interrupts.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/staging/nvec/nvec.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 815065837ce7..a93208adbfcf 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -821,8 +821,8 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	if (IS_ERR(base))
 		return PTR_ERR(base);
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!res) {
+	nvec->irq = platform_get_irq(pdev, 0);
+	if (nvec->irq < 0) {
 		dev_err(&pdev->dev, "no irq resource?\n");
 		return -ENODEV;
 	}
@@ -840,7 +840,6 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	}
 
 	nvec->base = base;
-	nvec->irq = res->start;
 	nvec->i2c_clk = i2c_clk;
 	nvec->rx = &nvec->msg_pool[0];
 
-- 
2.0.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

[parent not found: <1406632575-26075-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

* Re: [PATCH 2/2] staging/nvec: Use platform_get_irq()
  2014-07-29 11:16   ` Thierry Reding
@ 2014-07-29 20:24       ` Marc Dietrich
  -1 siblings, 0 replies; 8+ messages in thread
From: Marc Dietrich @ 2014-07-29 20:24 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Julian Andres Klode, Greg Kroah-Hartman,
	ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Am Dienstag 29 Juli 2014, 13:16:15 schrieb Thierry Reding:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> As opposed to platform_get_resource(), the platform_get_irq() function
> has special code to handle driver probe deferral when booting using DT
> and where an interrupt provider hasn't been registered yet. While this
> is unlikely to become an issue for nvec, platform_get_irq() is the
> recommended way to get at interrupts.
> 
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Thanks again, Thierry!

Acked-by: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>



> ---
>  drivers/staging/nvec/nvec.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 815065837ce7..a93208adbfcf 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -821,8 +821,8 @@ static int tegra_nvec_probe(struct platform_device
> *pdev) if (IS_ERR(base))
>  		return PTR_ERR(base);
> 
> -	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -	if (!res) {
> +	nvec->irq = platform_get_irq(pdev, 0);
> +	if (nvec->irq < 0) {
>  		dev_err(&pdev->dev, "no irq resource?\n");
>  		return -ENODEV;
>  	}
> @@ -840,7 +840,6 @@ static int tegra_nvec_probe(struct platform_device
> *pdev) }
> 
>  	nvec->base = base;
> -	nvec->irq = res->start;
>  	nvec->i2c_clk = i2c_clk;
>  	nvec->rx = &nvec->msg_pool[0];

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] staging/nvec: Use platform_get_irq()
@ 2014-07-29 20:24       ` Marc Dietrich
  0 siblings, 0 replies; 8+ messages in thread
From: Marc Dietrich @ 2014-07-29 20:24 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Julian Andres Klode, Greg Kroah-Hartman, ac100, linux-tegra,
	devel, linux-kernel

Am Dienstag 29 Juli 2014, 13:16:15 schrieb Thierry Reding:
> From: Thierry Reding <treding@nvidia.com>
> 
> As opposed to platform_get_resource(), the platform_get_irq() function
> has special code to handle driver probe deferral when booting using DT
> and where an interrupt provider hasn't been registered yet. While this
> is unlikely to become an issue for nvec, platform_get_irq() is the
> recommended way to get at interrupts.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Thanks again, Thierry!

Acked-by: Marc Dietrich <marvin24@gmx.de>



> ---
>  drivers/staging/nvec/nvec.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 815065837ce7..a93208adbfcf 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -821,8 +821,8 @@ static int tegra_nvec_probe(struct platform_device
> *pdev) if (IS_ERR(base))
>  		return PTR_ERR(base);
> 
> -	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -	if (!res) {
> +	nvec->irq = platform_get_irq(pdev, 0);
> +	if (nvec->irq < 0) {
>  		dev_err(&pdev->dev, "no irq resource?\n");
>  		return -ENODEV;
>  	}
> @@ -840,7 +840,6 @@ static int tegra_nvec_probe(struct platform_device
> *pdev) }
> 
>  	nvec->base = base;
> -	nvec->irq = res->start;
>  	nvec->i2c_clk = i2c_clk;
>  	nvec->rx = &nvec->msg_pool[0];


^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <1406632575-26075-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

* Re: [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()
  2014-07-29 11:16 ` Thierry Reding
@ 2014-07-29 20:23     ` Marc Dietrich
  -1 siblings, 0 replies; 8+ messages in thread
From: Marc Dietrich @ 2014-07-29 20:23 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Julian Andres Klode, Greg Kroah-Hartman,
	ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Am Dienstag 29 Juli 2014, 13:16:14 schrieb Thierry Reding:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> The mfd_add_devices() function takes a struct resource * as fifth
> argument, but the nvec driver passes in a void __iomem *. The driver
> gets away with it because none of the subdevices ever directly access
> the registers.
> 
> Since subdevices never need to access the registers we can simply pass
> NULL instead.
> 
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Acked-by: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>

> ---
>  drivers/staging/nvec/nvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 0a5c84ad3f41..815065837ce7 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -893,7 +893,7 @@ static int tegra_nvec_probe(struct platform_device
> *pdev) }
> 
>  	ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
> -			      ARRAY_SIZE(nvec_devices), base, 0, NULL);
> +			      ARRAY_SIZE(nvec_devices), NULL, 0, NULL);
>  	if (ret)
>  		dev_err(nvec->dev, "error adding subdevices\n");

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()
@ 2014-07-29 20:23     ` Marc Dietrich
  0 siblings, 0 replies; 8+ messages in thread
From: Marc Dietrich @ 2014-07-29 20:23 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Julian Andres Klode, Greg Kroah-Hartman, ac100, linux-tegra,
	devel, linux-kernel

Am Dienstag 29 Juli 2014, 13:16:14 schrieb Thierry Reding:
> From: Thierry Reding <treding@nvidia.com>
> 
> The mfd_add_devices() function takes a struct resource * as fifth
> argument, but the nvec driver passes in a void __iomem *. The driver
> gets away with it because none of the subdevices ever directly access
> the registers.
> 
> Since subdevices never need to access the registers we can simply pass
> NULL instead.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Acked-by: Marc Dietrich <marvin24@gmx.de>

> ---
>  drivers/staging/nvec/nvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 0a5c84ad3f41..815065837ce7 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -893,7 +893,7 @@ static int tegra_nvec_probe(struct platform_device
> *pdev) }
> 
>  	ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
> -			      ARRAY_SIZE(nvec_devices), base, 0, NULL);
> +			      ARRAY_SIZE(nvec_devices), NULL, 0, NULL);
>  	if (ret)
>  		dev_err(nvec->dev, "error adding subdevices\n");


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-07-29 20:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-29 11:16 [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices() Thierry Reding
2014-07-29 11:16 ` Thierry Reding
2014-07-29 11:16 ` [PATCH 2/2] staging/nvec: Use platform_get_irq() Thierry Reding
2014-07-29 11:16   ` Thierry Reding
     [not found]   ` <1406632575-26075-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-29 20:24     ` Marc Dietrich
2014-07-29 20:24       ` Marc Dietrich
     [not found] ` <1406632575-26075-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-29 20:23   ` [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices() Marc Dietrich
2014-07-29 20:23     ` Marc Dietrich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.