[KJ] [PATCH 2.6.11.10] arch/cris: fixes static strings declaration

[KJ] [PATCH 2.6.11.10] arch/cris: fixes static strings declaration

[Ricardo Nabinger Sanchez]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

o Fixes strings declaration from char *str = ""; to char str[] = "";,
  avoiding the extra pointer, as noted by Jeff Garzik.  The strings'
  contents are not changed after declared.

 arch/cris/arch-v10/drivers/axisflashmap.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Signed-off-by: Ricardo Nabinger Sanchez <rnsanchez@terra.com.br>

[-- Attachment #2: string_fix_arch_cris.patch --]
[-- Type: text/plain, Size: 781 bytes --]

diff -urNp -X dontdiff linux-2.6.11.10/arch/cris/arch-v10/drivers/axisflashmap.c mod-linux-2.6.11.10/arch/cris/arch-v10/drivers/axisflashmap.c
--- linux-2.6.11.10/arch/cris/arch-v10/drivers/axisflashmap.c	2005-05-16 14:50:30.000000000 -0300
+++ mod-linux-2.6.11.10/arch/cris/arch-v10/drivers/axisflashmap.c	2005-05-25 23:59:46.000000000 -0300
@@ -393,7 +393,7 @@ static int __init init_axis_flash(void)
 	struct partitiontable_head *ptable_head = NULL;
 	struct partitiontable_entry *ptable;
 	int use_default_ptable = 1; /* Until proven otherwise. */
-	const char *pmsg = "  /dev/flash%d at 0x%08x, size 0x%08x\n";
+	const char pmsg[] = "  /dev/flash%d at 0x%08x, size 0x%08x\n";
 
 	if (!(mymtd = flash_probe())) {
 		/* There's no reason to use this module if no flash chip can

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.11.10] arch/cris: fixes static strings declaration

[Alexey Dobriyan]

On Thursday 26 May 2005 19:25, Ricardo Nabinger Sanchez wrote:
> o Fixes strings declaration from char *str = ""; to char str[] = "";,
>   avoiding the extra pointer, as noted by Jeff Garzik.

>  arch/cris/arch-v10/drivers/axisflashmap.c |    2 +-

What's the difference in .text and .data sizes?
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.11.10] arch/cris: fixes static strings declaration

[Ricardo Nabinger Sanchez]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

Quoting  Alexey Dobriyan <adobriyan@gmail.com>
Sent on  Thu, 26 May 2005 20:35:55 +0400

> What's the difference in .text and .data sizes?

It's small, but as there are lots of occurences which may be corrected
(there are about 475 in total, including those which must be done that
way -- ie, correct).

From the TODO:

=====
From: Jeff Garzik <jgarzik at mandrakesoft dot com>

1) The string form

        [const] char *foo = "blah";

creates two variables in the final assembly output, a static string, and
a char pointer to the static string.  The alternate string form

        [const] char foo[] = "blah";

is better because it declares a single variable.
...
=====


-- 
Ricardo Nabinger Sanchez
GNU/Linux #140696 [http://counter.li.org]
Slackware Linux + FreeBSD

    How long a minute is depends on which 
    side of the bathroom door you're on.


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.11.10] arch/cris: fixes static strings declaration

[Alexey Dobriyan]

On Thursday 26 May 2005 21:21, Ricardo Nabinger Sanchez wrote:
> Quoting  Alexey Dobriyan <adobriyan@gmail.com>
> Sent on  Thu, 26 May 2005 20:35:55 +0400
> 
> > What's the difference in .text and .data sizes?
> 
> It's small,

I want to see size(1) output on cross-compiled .o

IIRC the difference depends on gcc version and can even be positive.

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.11.10] arch/cris: fixes static strings declaration

[walter harms]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

hi Alexey,
you ask for it :)

  cris-gcc -v
Reading specs from /usr/local/cris/lib/gcc-lib/cris/2.96/specs
gcc version 2.96 Axis release R46/1.25

testprogramm:

#include <stdio.h>
//char *foo = "blah";
char foo[]="blah";
int main()
{
printf("%s\n",foo);

}

  size test_string  (char [])
    text    data     bss     dec     hex filename
     769     252      36    1057     421 test_string


size test_string2  (char *)
    text    data     bss     dec     hex filename
     777     248      40    1065     429 test_string2


sorry, i could not resist :)

re,
	walter



Alexey Dobriyan wrote:
> On Thursday 26 May 2005 21:21, Ricardo Nabinger Sanchez wrote:
> 
>>Quoting  Alexey Dobriyan <adobriyan@gmail.com>
>>Sent on  Thu, 26 May 2005 20:35:55 +0400
>>
>>
>>>What's the difference in .text and .data sizes?
>>
>>It's small,
> 
> 
> I want to see size(1) output on cross-compiled .o
> 
> IIRC the difference depends on gcc version and can even be positive.
> 


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.11.10] arch/cris: fixes static strings declaration

[Alexey Dobriyan]

On Thursday 26 May 2005 22:27, walter harms wrote:

> you ask for it :)
> 
>   cris-gcc -v
> Reading specs from /usr/local/cris/lib/gcc-lib/cris/2.96/specs
> gcc version 2.96 Axis release R46/1.25

Aha!

> #include <stdio.h>
> //char *foo = "blah";
> char foo[]="blah";
> int main()
> {
> printf("%s\n",foo);
> 
> }
> 
>   size test_string  (char [])
>     text    data     bss     dec     hex filename
>      769     252      36    1057     421 test_string
> 
> 
> size test_string2  (char *)
>     text    data     bss     dec     hex filename
>      777     248      40    1065     429 test_string2
> 
> 
> sorry, i could not resist :)

Care to repeat this on arch/cris/arch-v10/drivers/axisflashmap.o ? ;-)
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors