From: Mark Lord <mlord@pobox.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@suse.de>,
Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Subject: Re: [PATCH] libata: fix use-after-free during driver unload/unplug
Date: Thu, 26 May 2005 17:33:13 -0400 [thread overview]
Message-ID: <42964099.6000207@pobox.com> (raw)
In-Reply-To: <42962379.5000206@pobox.com>
Hi Jeff!
Jeff Garzik wrote:
>
> * add ->host_stop_prewalk() hook, use it in sata_qstor.c (hi Mark).
> sata_qstor appears to require the host-stop-before-port-stop ordering
> that existed prior to applying the attached patch.
Mmm.. I'm a little bit rusty here, but I don't think qstor
cares about the order, so long as ports are marked with
ATA_FLAG_PORT_DISABLED before invoking port_stop().
I've tried to allow disabling/enabling individual ports
on-the-fly as needed, even though it never really happens
in practice. So host_stop() kills the whole chip, whereas
port_stop() I took to mean just one of the four SATA ports.
Cheers
--
Mark Lord
Real-Time Remedies Inc.
mlord@pobox.com
next prev parent reply other threads:[~2005-05-26 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 19:28 [PATCH] libata: fix use-after-free during driver unload/unplug Jeff Garzik
2005-05-26 21:33 ` Mark Lord [this message]
2005-05-27 1:21 ` Jeff Garzik
2005-05-27 1:32 ` Mark Lord
2005-05-27 2:00 ` [PATCH][RFT] " Jeff Garzik
2005-05-27 4:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42964099.6000207@pobox.com \
--to=mlord@pobox.com \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.