From: Jeff Garzik <jgarzik@pobox.com>
To: Jens Axboe <axboe@suse.de>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Playing with SATA NCQ
Date: Fri, 27 May 2005 00:41:59 -0400 [thread overview]
Message-ID: <4296A517.3020502@pobox.com> (raw)
In-Reply-To: <20050526140058.GR1419@suse.de>
Jens Axboe wrote:
> @@ -189,7 +194,7 @@
> .ioctl = ata_scsi_ioctl,
> .queuecommand = ata_scsi_queuecmd,
> .eh_strategy_handler = ata_scsi_error,
> - .can_queue = ATA_DEF_QUEUE,
> + .can_queue = ATA_MAX_QUEUE,
> .this_id = ATA_SHT_THIS_ID,
> .sg_tablesize = AHCI_MAX_SG,
> .max_sectors = ATA_MAX_SECTORS,
> @@ -200,7 +205,7 @@
> .dma_boundary = AHCI_DMA_BOUNDARY,
> .slave_configure = ata_scsi_slave_config,
> .bios_param = ata_std_bios_param,
> - .ordered_flush = 1,
> + .ordered_flush = 0, /* conflicts with NCQ for now */
> };
>
> static struct ata_port_operations ahci_ops = {
Also, you'll probably want to implement ata_scsi_change_queue_depth, and
reference it in ahci.c (and other NCQ-capable drivers).
Jeff
next prev parent reply other threads:[~2005-05-27 4:42 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 14:00 Playing with SATA NCQ Jens Axboe
2005-05-26 16:25 ` Jeff Garzik
2005-05-26 17:07 ` Jens Axboe
2005-05-26 17:11 ` Jens Axboe
2005-05-26 17:15 ` Jeff Garzik
2005-05-26 17:33 ` Jens Axboe
2005-05-26 19:49 ` Jeff Garzik
2005-05-26 20:30 ` Jens Axboe
2005-05-27 7:20 ` Jens Axboe
2005-05-27 7:29 ` Jeff Garzik
2005-05-27 7:33 ` Jens Axboe
2005-05-27 7:51 ` Jeff Garzik
2005-05-27 8:00 ` Jens Axboe
2005-05-27 8:23 ` Jeff Garzik
2005-05-26 21:50 ` Mark Lord
2005-05-27 6:28 ` Jens Axboe
2005-05-27 6:58 ` Jeff Garzik
2005-05-27 7:15 ` Jens Axboe
2005-05-27 4:41 ` Jeff Garzik [this message]
2005-05-27 6:39 ` Jens Axboe
2005-05-27 21:40 ` Michael Thonke
2005-05-27 22:16 ` Jeff Garzik
2005-05-27 22:30 ` Michael Thonke
2005-05-28 12:12 ` Jens Axboe
2005-05-29 13:01 ` Michael Thonke
2005-05-29 14:09 ` Mark Lord
2005-05-29 14:24 ` Tyler
2005-05-29 15:22 ` Eric D. Mudama
2005-05-29 19:04 ` Jens Axboe
2005-05-29 19:05 ` Jeff Garzik
2005-05-29 19:21 ` Jens Axboe
2005-05-29 19:03 ` Jens Axboe
2005-05-29 20:12 ` Michael Thonke
2005-05-29 20:17 ` Jeff Garzik
2005-05-30 6:05 ` Jens Axboe
2005-05-30 6:07 ` Jens Axboe
2005-05-29 18:10 ` Michael Thonke
2005-05-29 19:06 ` Jens Axboe
2005-05-29 16:03 ` Erik Slagter
2005-05-29 16:34 ` Jeff Garzik
2005-05-29 16:50 ` Erik Slagter
2005-05-29 16:59 ` Jeff Garzik
2005-05-29 17:23 ` Erik Slagter
2005-05-29 17:29 ` Jeff Garzik
2005-05-29 17:45 ` Erik Slagter
2005-05-29 18:01 ` Jeff Garzik
2005-05-29 18:10 ` Erik Slagter
2005-05-29 18:14 ` Jeff Garzik
2005-05-29 18:27 ` Michael Thonke
2005-05-29 18:31 ` Jeff Garzik
2005-05-29 16:57 ` Michael Thonke
2005-05-29 17:26 ` Erik Slagter
2005-05-30 0:06 ` Mark Lord
2005-05-30 7:29 ` Erik Slagter
2005-05-30 18:09 ` Mark Lord
2005-05-30 18:22 ` Erik Slagter
2005-05-30 18:25 ` Mark Lord
2005-05-30 18:34 ` Michael Thonke
2005-05-30 18:51 ` Jeff Garzik
2005-05-30 18:48 ` Jeff Garzik
2005-05-30 18:50 ` Jeff Garzik
2005-05-30 20:03 ` Erik Slagter
2005-05-30 20:19 ` Jeff Garzik
2005-05-31 7:44 ` Erik Slagter
2005-05-30 23:14 ` Mark Lord
2005-05-31 7:48 ` Erik Slagter
2005-05-31 8:05 ` Patrick McFarland
2005-05-29 21:49 ` Michael Thonke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4296A517.3020502@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.