From: Jeff Garzik <jgarzik@pobox.com>
To: Jens Axboe <axboe@suse.de>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SATA NCQ support
Date: Fri, 27 May 2005 19:47:52 -0400 [thread overview]
Message-ID: <4297B1A8.6090902@pobox.com> (raw)
In-Reply-To: <20050527084254.GU1435@suse.de>
Jens Axboe wrote:
> On Fri, May 27 2005, Jeff Garzik wrote:
>
>>Jens Axboe wrote:
>>
>>>Actually, I didn't look far enough up - ata_scsi_qc_new() already
>>>completes the command with QUEUE_FULL if ata_qc_new_init() fails. So
>>>there's no bug, but perhaps it would be cleaner to move it to
>>>ata_scsi_translate instead?
>>
>>Ah, ok.
>>
>>Yes, if you are in a cleaning mood, that would be a better location.
>
>
> Always in a code cleaning mood - here it is against vanilla, I've
> integrated it in the ncq stuff as well.
Committed to 'ncq' branch of libata-dev.git.
Jeff
next prev parent reply other threads:[~2005-05-27 23:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 7:03 [PATCH] SATA NCQ support Jens Axboe
2005-05-27 7:22 ` Jeff Garzik
2005-05-27 7:30 ` Jens Axboe
2005-05-27 7:37 ` Jeff Garzik
2005-05-27 7:47 ` Jens Axboe
2005-05-27 7:56 ` Jens Axboe
2005-05-27 8:24 ` Jeff Garzik
2005-05-27 8:27 ` Jeff Garzik
2005-05-27 8:28 ` Jeff Garzik
2005-05-27 8:35 ` Jens Axboe
2005-05-27 8:38 ` Jeff Garzik
2005-05-27 8:42 ` Jens Axboe
2005-05-27 23:47 ` Jeff Garzik [this message]
2005-05-27 13:18 ` Matthias Andree
2005-05-27 13:53 ` Jens Axboe
2005-05-27 14:46 ` Matthias Andree
2005-05-27 14:58 ` Jens Axboe
2005-05-29 13:16 ` Matthias Andree
2005-05-29 16:36 ` Jeff Garzik
2005-05-30 2:35 ` Eric D. Mudama
2005-05-30 3:41 ` Greg Stark
2005-05-30 4:04 ` Eric D. Mudama
2005-05-30 6:21 ` Greg Stark
2005-05-30 6:33 ` Jens Axboe
2005-05-30 12:16 ` Jens Axboe
2005-05-30 12:37 ` Jens Axboe
2005-05-30 14:51 ` Jens Axboe
2005-05-27 16:00 ` Jeff Garzik
[not found] <48Hix-88s-7@gated-at.bofh.it>
[not found] ` <48N4N-4B5-25@gated-at.bofh.it>
[not found] ` <48Pzt-6Kb-5@gated-at.bofh.it>
2005-05-31 0:00 ` Robert Hancock
2005-05-31 1:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4297B1A8.6090902@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.