sis5513.c patch take 2

sis5513.c patch take 2

[Andrew Hutchings]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Hi,

Is this patch safer?  I am burn-in testing it now and it seems work fine 
with UDMA transfers.  I added the PCI ID of the northbridge as suggested.

Regards
Andrew
-- 
Andrew Hutchings (A-Wing)
Linux Guru - Netserve Consultants Ltd. - http://www.domaincity.co.uk/
Admin - North Wales Linux User Group - http://www.nwlug.org.uk/
BOFH excuse 348: We're on Token Ring, and it looks like the token got loose.

[-- Attachment #2: sis5513-new.patch --]
[-- Type: text/x-patch, Size: 438 bytes --]

--- linux-2.6.12-rc6/drivers/ide/pci/sis5513.c	2005-06-06 16:22:29.000000000 +0100
+++ linux-2.6.12-rc6.new/drivers/ide/pci/sis5513.c	2005-06-09 17:41:07.000000000 +0100
@@ -87,6 +87,7 @@
 	u8 chipset_family;
 	u8 flags;
 } SiSHostChipInfo[] = {
+	{ "SiS760",	PCI_DEVICE_ID_SI_760,	ATA_133	 },
 	{ "SiS745",	PCI_DEVICE_ID_SI_745,	ATA_100  },
 	{ "SiS735",	PCI_DEVICE_ID_SI_735,	ATA_100  },
 	{ "SiS733",	PCI_DEVICE_ID_SI_733,	ATA_100  },

Re: sis5513.c patch take 2

[Bartlomiej Zolnierkiewicz]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi,

On 6/9/05, Andrew Hutchings <info@a-wing.co.uk> wrote:
> Hi,
> 
> Is this patch safer?  I am burn-in testing it now and it seems work fine
> with UDMA transfers.  I added the PCI ID of the northbridge as suggested.

Thanks, could you also try this simple debugging patch?
[ without applying your patch ]

It may be possible to add generic 965L support just like 962/936L one
(also NorthBridge<->SouthBridge mapping is not unique nowadays).

Bartlomiej

[-- Attachment #2: sis5513-debug1.patch --]
[-- Type: application/octet-stream, Size: 457 bytes --]

--- a/drivers/ide/pci/sis5513.c	2005-05-26 14:51:14.000000000 +0200
+++ b/drivers/ide/pci/sis5513.c	2005-06-09 14:19:44.000000000 +0200
@@ -765,6 +765,8 @@
 			pci_read_config_word(dev, PCI_DEVICE_ID, &trueid);
 			pci_write_config_dword(dev, 0x54, idemisc);
 
+			printk(KERN_INFO "SIS5513: trueid=0x%x\n", trueid);
+
 			if (trueid == 0x5518) {
 				printk(KERN_INFO "SIS5513: SiS 962/963 MuTIOL IDE UDMA133 controller\n");
 				chipset_family = ATA_133;

Re: sis5513.c patch take 2

[Andrew Hutchings]

Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> On 6/9/05, Andrew Hutchings <info@a-wing.co.uk> wrote:
> 
>>Hi,
>>
>>Is this patch safer?  I am burn-in testing it now and it seems work fine
>>with UDMA transfers.  I added the PCI ID of the northbridge as suggested.
> 
> 
> Thanks, could you also try this simple debugging patch?
> [ without applying your patch ]

Not a problem, just compiled it, the result is trueid=0x180

> It may be possible to add generic 965L support just like 962/936L one
> (also NorthBridge<->SouthBridge mapping is not unique nowadays).

I was thinking that you said to use the NorthBridge

Regards
Andrew

-- 
Andrew Hutchings (A-Wing)
Linux Guru - Netserve Consultants Ltd. - http://www.domaincity.co.uk/
Admin - North Wales Linux User Group - http://www.nwlug.org.uk/
BOFH excuse 178: short leg on process table