From: Joel Schopp <jschopp@austin.ibm.com>
To: Christoph Lameter <christoph@lameter.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Telemaque Ndizihiwe <telendiz@eircom.net>,
torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
Date: Mon, 20 Jun 2005 14:51:29 -0500 [thread overview]
Message-ID: <42B71E41.7080400@austin.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0506201154300.2245@graphe.net>
Christoph Lameter wrote:
> On Mon, 20 Jun 2005, Jeff Garzik wrote:
>
>
>>If you don't like goto, don't read kernel code!
>
>
> But his patch also cleans up a code quit a bit.
As a wider question, what is the practice for accepting patches without
functional changes that simply clean up code and make it look better?
BTW, I also agree that the gotos in this case keep the normal code flow
cleaner, while making the exceptions isolated well.
next prev parent reply other threads:[~2005-06-20 20:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 18:18 [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c Telemaque Ndizihiwe
2005-06-20 18:43 ` Jeff Garzik
2005-06-20 18:54 ` Christoph Lameter
2005-06-20 19:51 ` Joel Schopp [this message]
2005-06-20 20:38 ` Andrew Morton
2005-06-21 8:57 ` Martin Waitz
2005-06-21 16:05 ` Linus Torvalds
2005-06-20 19:07 ` Richard B. Johnson
2005-06-20 20:34 ` Mitchell Blank Jr
2005-06-20 22:06 ` Bill Davidsen
[not found] <Pine.LNX.4.62.0506201834460.5008@localhost.localdomain.suse.lists.linux.kernel>
[not found] ` <42B70E62.5070704@pobox.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.62.0506201154300.2245@graphe.net.suse.lists.linux.kernel>
[not found] ` <20050620133800.0dac1d97.akpm@osdl.org.suse.lists.linux.kernel>
2005-06-21 11:27 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B71E41.7080400@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=telendiz@eircom.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.