From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, telendiz@eircom.net
Subject: Re: [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
Date: 21 Jun 2005 13:27:45 +0200 [thread overview]
Message-ID: <p738y14c5la.fsf@verdi.suse.de> (raw)
In-Reply-To: <20050620133800.0dac1d97.akpm@osdl.org.suse.lists.linux.kernel>
Andrew Morton <akpm@osdl.org> writes:
>
> The old trick to make the error-handling code out-of-line shouldn't be
> needed nowadays - IS_ERR uses unlikely(), which is supposed to handle that
> stuff.
In fact it doesn't even work anymore with -freorder-blocks (which is
default on i386). Without unlikely gcc 3.3/3.4 will happily move the out of
line block back. I was told that newer gcc gives a bit more value
to user gotos, but it doesn't help on the older compilers.
-Andi (who also thinks there are too many gotos in the kernel and
many should be cleaned up)
next parent reply other threads:[~2005-06-21 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.62.0506201834460.5008@localhost.localdomain.suse.lists.linux.kernel>
[not found] ` <42B70E62.5070704@pobox.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.62.0506201154300.2245@graphe.net.suse.lists.linux.kernel>
[not found] ` <20050620133800.0dac1d97.akpm@osdl.org.suse.lists.linux.kernel>
2005-06-21 11:27 ` Andi Kleen [this message]
2005-06-20 18:18 [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c Telemaque Ndizihiwe
2005-06-20 18:43 ` Jeff Garzik
2005-06-20 18:54 ` Christoph Lameter
2005-06-20 19:51 ` Joel Schopp
2005-06-20 20:38 ` Andrew Morton
2005-06-21 8:57 ` Martin Waitz
2005-06-21 16:05 ` Linus Torvalds
2005-06-20 19:07 ` Richard B. Johnson
2005-06-20 20:34 ` Mitchell Blank Jr
2005-06-20 22:06 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p738y14c5la.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=telendiz@eircom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.