All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: xen-devel <xen-devel@lists.xensource.com>,
	xense-devel@lists.xensource.com
Subject: [RFC] Cleaning up SCM debug
Date: Wed, 22 Jun 2005 22:20:12 -0500	[thread overview]
Message-ID: <42BA2A6C.5000004@us.ibm.com> (raw)

Hi,

public/acm.h defines both an ACM_DEBUG flag and a printkd function that, 
if ACM_DEBUG is defined will convert to a printk.  public/acm.h is 
included by userspace applications where printk isn't necessarily 
meaningful.  Furthermore, it appears ACM_DEBUG is only used within Xen 
anyway so making it apart of the public headers doesn't make much sense.

Therefore, I'd like to move ACM_DEBUG and printkd into acm/acm_core.h.  
While at it, it seems like a good idea to change the printkd into either 
one of the existing Xen debug macros or to get rid of it altogether.

I wanted to check first to see if there was an emerging standard macro 
(a quick glance shows printk, DPRINTK, PRINT, and I'm sure there are at 
least a few more).  Recommendations are appreciated.

Regards,

Anthony Liguori

             reply	other threads:[~2005-06-23  3:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-23  3:20 Anthony Liguori [this message]
2005-06-23  9:44 ` [RFC] Cleaning up SCM debug Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42BA2A6C.5000004@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xense-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.