From: Arun Sharma <arun.sharma@intel.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: George Washington Dunlap III <dunlapg@umich.edu>,
xen-devel List <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Fix vnc-dryrun option interaction
Date: Thu, 23 Jun 2005 09:57:32 -0700 [thread overview]
Message-ID: <42BAE9FC.2030103@intel.com> (raw)
In-Reply-To: <670517d5e836a3caaa16706e6fb84145@cl.cam.ac.uk>
Keir Fraser wrote:
> On 23 Jun 2005, at 15:23, George Washington Dunlap III wrote:
>
>> A patch that was applied yesterday tried to turn the vnc option off if
>> dryrun was set. Unfortunately, the way it was actually coded turned
>> vnc ON if dryrun was not set! I think this patch should fix it
>> (someone who actually uses vnc & dryrun should test it, though).
>>
>> -George
>
>
> That patch was originally from Arun Sharma at Intel. I've cc'ed him.
Please apply this patch. It fixes two problems:
- vnc shouldn't be turned on by default (I didn't spot it because I
usually have VNC on)
- If it's a boolean, its stringified version seen by xend would be
"True" or "False". An integer is easier to parse in xend. A patch that I
have in my queue expects it to be an integer.
-Arun
next prev parent reply other threads:[~2005-06-23 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 14:23 [PATCH] Fix vnc-dryrun option interaction George Washington Dunlap III
2005-06-23 15:59 ` Keir Fraser
2005-06-23 16:57 ` Arun Sharma [this message]
2005-06-23 19:52 ` Keir Fraser
2005-06-23 20:10 ` Arun Sharma
2005-06-23 20:30 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42BAE9FC.2030103@intel.com \
--to=arun.sharma@intel.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=dunlapg@umich.edu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.