From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira <pablo@eurodev.net>
Cc: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: Re: [RFC][PATCH] kill the fake conntrack
Date: Sat, 25 Jun 2005 14:48:39 +0200 [thread overview]
Message-ID: <42BD52A7.2090107@trash.net> (raw)
In-Reply-To: <42BD513E.6090306@eurodev.net>
Pablo Neira wrote:
> The patch attached kills the fake conntrack and propose a new logic to
> explicitely set connection as untracked. We set nfct to NULL and use a
> new flag called IP_CT_UNTRACKED for nfctinfo. I've slightely tested it
> here and works fine.
>
> Comments welcome.
What is the advantage of this patch? Its changing the assumption
that skb->nfctinfo is only valid if skb->nfct is set, so you probably
need to set nfctinfo to 0 in nf_reset as well. This alone is a reason
not to do it IMO.
Regards
Patrick
next prev parent reply other threads:[~2005-06-25 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-25 12:42 [RFC][PATCH] kill the fake conntrack Pablo Neira
2005-06-25 12:48 ` Patrick McHardy [this message]
2005-06-25 13:12 ` Pablo Neira
2005-06-25 13:20 ` Pablo Neira
2005-06-25 13:29 ` Patrick McHardy
2005-06-25 18:47 ` Pablo Neira
2005-06-25 19:00 ` Patrick McHardy
2005-08-28 12:05 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42BD52A7.2090107@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.