From: Hannes Reinecke <hare@suse.de>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Remove newline from pci MODALIAS variable
Date: Tue, 28 Jun 2005 14:57:10 +0200 [thread overview]
Message-ID: <42C14926.1040101@suse.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
Hi Greg,
the pci core sends out a hotplug event variable MODALIAS with a trailing
newline. This is inconsistent with all other event variables and breaks
some hotplug tools. This patch removes the said newline.
Please apply.
Cheers,
Hannes
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux AG S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
[-- Attachment #2: pci-hotplug-remove-nl --]
[-- Type: text/plain, Size: 747 bytes --]
From: Hannes Reinecke <hare@suse.de>
Subject: Remove newline from MODALIAS
PCI hotplug events carry a newline in the MODALIAS variable.
This confuses scripts unneccesarily.
--- linux-2.6.12/drivers/pci/hotplug.c.orig 2005-06-23 09:33:03.000000000 +0200
+++ linux-2.6.12/drivers/pci/hotplug.c 2005-06-23 09:33:16.000000000 +0200
@@ -54,7 +54,7 @@ int pci_hotplug (struct device *dev, cha
envp[i++] = scratch;
length += scnprintf (scratch, buffer_size - length,
- "MODALIAS=pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n",
+ "MODALIAS=pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x",
pdev->vendor, pdev->device,
pdev->subsystem_vendor, pdev->subsystem_device,
(u8)(pdev->class >> 16), (u8)(pdev->class >> 8),
reply other threads:[~2005-06-28 12:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C14926.1040101@suse.de \
--to=hare@suse.de \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.