All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Remove newline from pci MODALIAS variable
@ 2005-06-28 12:57 Hannes Reinecke
  0 siblings, 0 replies; only message in thread
From: Hannes Reinecke @ 2005-06-28 12:57 UTC (permalink / raw)
  To: Greg KH; +Cc: Andrew Morton, Linux Kernel

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Hi Greg,

the pci core sends out a hotplug event variable MODALIAS with a trailing
newline. This is inconsistent with all other event variables and breaks
some hotplug tools. This patch removes the said newline.

Please apply.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux AG				S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[-- Attachment #2: pci-hotplug-remove-nl --]
[-- Type: text/plain, Size: 747 bytes --]

From: Hannes Reinecke <hare@suse.de>
Subject: Remove newline from MODALIAS

PCI hotplug events carry a newline in the MODALIAS variable.
This confuses scripts unneccesarily.

--- linux-2.6.12/drivers/pci/hotplug.c.orig	2005-06-23 09:33:03.000000000 +0200
+++ linux-2.6.12/drivers/pci/hotplug.c	2005-06-23 09:33:16.000000000 +0200
@@ -54,7 +54,7 @@ int pci_hotplug (struct device *dev, cha
 
 	envp[i++] = scratch;
 	length += scnprintf (scratch, buffer_size - length,
-			    "MODALIAS=pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n",
+			    "MODALIAS=pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x",
 			    pdev->vendor, pdev->device,
 			    pdev->subsystem_vendor, pdev->subsystem_device,
 			    (u8)(pdev->class >> 16), (u8)(pdev->class >> 8),

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-28 12:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-28 12:57 [PATCH] Remove newline from pci MODALIAS variable Hannes Reinecke

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.