* [PATCH][4/5] Remove debug printks.
@ 2005-07-10 19:03 Arun Sharma
2005-07-10 21:33 ` David Hopwood
0 siblings, 1 reply; 2+ messages in thread
From: Arun Sharma @ 2005-07-10 19:03 UTC (permalink / raw)
To: Ian Pratt, Keir Fraser; +Cc: xen-devel
Remove debug printks.
Sometimes they generate too much output on serial console.
Signed-off-by: Arun Sharma <arun.sharma@intel.com>
diff -r 2ae37d882cf5 -r 14097f22fe2e xen/arch/x86/vmx.c
--- a/xen/arch/x86/vmx.c Fri Jul 8 00:18:10 2005
+++ b/xen/arch/x86/vmx.c Fri Jul 8 00:56:53 2005
@@ -1455,12 +1484,9 @@
if (idtv_info_field & 0x800) { /* valid error code */
unsigned long error_code;
- printk("VMX exit %x: %x/%lx\n",
- exit_reason, idtv_info_field, error_code);
__vmread(VM_EXIT_INTR_ERROR_CODE, &error_code);
__vmwrite(VM_ENTRY_EXCEPTION_ERROR_CODE, error_code);
- } else
- printk("VMX exit %x: %x\n", exit_reason, idtv_info_field);
+ }
}
VMX_DBG_LOG(DBG_LEVEL_1, "idtv_info_field=%x", idtv_info_field);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][4/5] Remove debug printks.
2005-07-10 19:03 [PATCH][4/5] Remove debug printks Arun Sharma
@ 2005-07-10 21:33 ` David Hopwood
0 siblings, 0 replies; 2+ messages in thread
From: David Hopwood @ 2005-07-10 21:33 UTC (permalink / raw)
To: xen-devel
Arun Sharma wrote:
> Remove debug printks.
>
> Sometimes they generate too much output on serial console.
Not to mention that error_code was used before being initialized:
> unsigned long error_code;
> - printk("VMX exit %x: %x/%lx\n",
> - exit_reason, idtv_info_field, error_code);
--
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-10 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-10 19:03 [PATCH][4/5] Remove debug printks Arun Sharma
2005-07-10 21:33 ` David Hopwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.