mlmmj 1.2.9 UNOFFICIAL release, with qmail support

mlmmj 1.2.9 UNOFFICIAL release, with qmail support

[fifadd]

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

Hi Mads,

in attach you can find the version 1.2.9 of mlmmj. This version support properly
the qmail MTA. I have updated a lot of files, also the TODO, ChangeLog, VERSION,
etc. Now you can easily change the constant RECIPDELIM to make mlmmj compatible
with qmail.
I have added the italian list texts and also a README.qmail.
If you want check my improvements, you can use WinMerge or similar to compare
sources. I cannot catalogue all the changes here, but you can read REAME.qmail
and ChangeLog to get an idea.
Attention! This is not an official release, but it's running on my server
just now. You can use it at your own risk!
Before to commit changes and release the official 1.2.9 version look at the
new sources and check them please.

Kind regards

-Filippo F. Fadda
http://programmazione.it



[-- Attachment #2: mlmmj-1.2.9.tar.gz --]
[-- Type: application/x-gzip, Size: 185411 bytes --]

Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support

[Mads Martin Joergensen]

* fifadd@tin.it <fifadd@tin.it> [Jul 18. 2005 18:20]:
> in attach you can find the version 1.2.9 of mlmmj. This version support properly
> the qmail MTA. I have updated a lot of files, also the TODO, ChangeLog, VERSION,
> etc. Now you can easily change the constant RECIPDELIM to make mlmmj compatible
> with qmail.
> I have added the italian list texts and also a README.qmail.
> If you want check my improvements, you can use WinMerge or similar to compare
> sources. I cannot catalogue all the changes here, but you can read REAME.qmail
> and ChangeLog to get an idea.
> Attention! This is not an official release, but it's running on my server
> just now. You can use it at your own risk!
> Before to commit changes and release the official 1.2.9 version look at the
> new sources and check them please.

Sounds nice. I'm going to diff it against 1.2.8 and have a look this
evening.

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support

[Mads Martin Joergensen]

* fifadd@tin.it <fifadd@tin.it> [Jul 18. 2005 18:20]:
> Hi Mads,
> 
> in attach you can find the version 1.2.9 of mlmmj. This version support properly
> the qmail MTA. I have updated a lot of files, also the TODO, ChangeLog, VERSION,
> etc. Now you can easily change the constant RECIPDELIM to make mlmmj compatible
> with qmail.
> I have added the italian list texts and also a README.qmail.
> If you want check my improvements, you can use WinMerge or similar to compare
> sources. I cannot catalogue all the changes here, but you can read REAME.qmail
> and ChangeLog to get an idea.
> Attention! This is not an official release, but it's running on my server
> just now. You can use it at your own risk!
> Before to commit changes and release the official 1.2.9 version look at the
> new sources and check them please.

There's a few memory leaks, and it's also changing the coding style of
the existing code.

What if you try removing all the stuff you commented out, and then
instead of sending a whole tar-ball, create a patch with:

$ diff -urpN mlmmj-1.2.8 mlmmj-1.2.9 > recipdelim.patch

and then gzip the patch?

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support

[fifadd]

Memory leaks? This is very strange because I don't make any malloc that I
remember. Where did you find them?
I have inserted only some comments FFF, that you can easily catch (then remove)
using a grep 'FFF' *. But there are changes in a lof of files and only three
or four of them are signed by FFF characters sequence, If you need it I can
make a patch, but you can make it by yourself. Simply remove the few FFF
comments from listcontrol.c, mlmmj-process.c and mlmmj-send.c. Also remove
the commented code that follows the FFF comment only.
I have used the existence code style, and the existence functions, like your
contactstr.
I'm waiting your response.

Kind regards.

-Filippo Fadda

>-- Messaggio originale --
>Date: Mon, 18 Jul 2005 22:29:33 +0200
>From: Mads Martin Joergensen <mmj@mmj.dk>
>To: mlmmj@mmj.dk
>Subject: Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support

>There's a few memory leaks, and it's also changing the coding style of
>the existing code.
>
>What if you try removing all the stuff you commented out, and then
>instead of sending a whole tar-ball, create a patch with:
>
>$ diff -urpN mlmmj-1.2.8 mlmmj-1.2.9 > recipdelim.patch
>
>and then gzip the patch?
>
>-- 
>Mads Martin Joergensen, http://mmj.dk
>"Why make things difficult, when it is possible to make them cryptic
> and totally illogical, with just a little bit more effort?"
>                                -- A. P. J.

Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support

[Mads Martin Joergensen]

* fifadd@tin.it <fifadd@tin.it> [Jul 18. 2005 23:33]:
> Memory leaks? This is very strange because I don't make any malloc
> that I remember. Where did you find them?

 From mlmmj-process.c:
 if(owner && strncmp(recipdelim, concatstr(2, RECIPDELIM, "owner@"), 7) = 0) {

concatstr() returns a string that needs to be free'd afterwards, since
it mallocs room for the new string it concats.

> I have inserted only some comments FFF, that you can easily catch (then remove)
> using a grep 'FFF' *. But there are changes in a lof of files and only three
> or four of them are signed by FFF characters sequence, If you need it I can
> make a patch, but you can make it by yourself. Simply remove the few FFF
> comments from listcontrol.c, mlmmj-process.c and mlmmj-send.c. Also remove
> the commented code that follows the FFF comment only.

But when I get a diff it's so much easier to see what have changed,
since it's not just one line adding a comment closure several lines
down, but explicitly showing me what's being removed. You don't have to
comment you you've been doing stuff.

And since it's not my code, I feel uncomfortable whether I really catch
everything when removing stuff.

So if you don't mind just removing everything you want to remove and add
all that's needed to make it work with qmail and send the patch, I would
be most grateful.

> I have used the existence code style, and the existence functions, like your
> contactstr.

Yeah, I see that. I was just puzzled that some places in the patch it
seemed the indentation was different. I use tabs for indentation.

Thanks!

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support

[Morten K. Poulsen]

On Mon, Jul 18, 2005 at 11:41:03PM +0200, Mads Martin Joergensen wrote:
>  if(owner && strncmp(recipdelim, concatstr(2, RECIPDELIM, "owner@"), 7) = 0) {

Wouldn't

if(owner && strncmp(recipdelim, RECIPDELIM"owner@", 7) = 0) {

do the same? Then the compiler handles the concatenation.

Morten

-- 
Morten K. Poulsen <morten@afdelingp.dk>
http://www.afdelingp.dk/

Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support

[Mads Martin Joergensen]

* Morten K. Poulsen <morten@afdelingp.dk> [Jul 19. 2005 11:10]:
> On Mon, Jul 18, 2005 at 11:41:03PM +0200, Mads Martin Joergensen wrote:
> >  if(owner && strncmp(recipdelim, concatstr(2, RECIPDELIM, "owner@"), 7) = 0) {
> 
> Wouldn't
> 
> if(owner && strncmp(recipdelim, RECIPDELIM"owner@", 7) = 0) {
> 
> do the same? Then the compiler handles the concatenation.

Indeed! I totally forgot about that.

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support

[fifadd]

>-- Messaggio originale --
>Date: Tue, 19 Jul 2005 11:11:32 +0200
>From: Mads Martin Joergensen <mmj@mmj.dk>
>To: mlmmj@mmj.dk
>Subject: Re: mlmmj 1.2.9 UNOFFICIAL release, with qmail support
>
>
>* Morten K. Poulsen <morten@afdelingp.dk> [Jul 19. 2005 11:10]:
>> On Mon, Jul 18, 2005 at 11:41:03PM +0200, Mads Martin Joergensen wrote:
>> >  if(owner && strncmp(recipdelim, concatstr(2, RECIPDELIM, "owner@"),
>7) == 0) {
>> 
>> Wouldn't
>> 
>> if(owner && strncmp(recipdelim, RECIPDELIM"owner@", 7) == 0) {
>> 
>> do the same? Then the compiler handles the concatenation.
>
>Indeed! I totally forgot about that.

Idem!

-Filippo