All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org, "Luck, Tony" <tony.luck@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	long <tlnguyen@snoqualmie.dp.intel.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: Re: [PATCH 2.6.13-rc1 03/10] IOCHK interface for I/O error handling/detecting
Date: Wed, 13 Jul 2005 01:33:12 +0000	[thread overview]
Message-ID: <42D46F58.4070900@jp.fujitsu.com> (raw)
In-Reply-To: <20050712195120.GE26607@austin.ibm.com>

Linas Vepstas wrote:
> Thus, one wouldn't want to perform an iochk_read() in this way unless
> one was already pretty sure that an error had already occured ... 

If another kind of I/O error detecting system finds a error before
performing iochk_read(), it can prevents coming iochk_read() from
spending such crazy cycles in have_error() by marking cookie->error.

 >> int iochk_read(iocookie *cookie)
 >>  {
 >> +	if (cookie->error || have_error(cookie->dev))

Isn't it enough?

And as Ben said, it seems that ppc64 can have its own special iochk_*,
unless calling pci_read_config_word() ;-)

Thanks,
H.Seto


WARNING: multiple messages have this Message-ID (diff)
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org, "Luck, Tony" <tony.luck@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	long <tlnguyen@snoqualmie.dp.intel.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: Re: [PATCH 2.6.13-rc1 03/10] IOCHK interface for I/O error handling/detecting
Date: Wed, 13 Jul 2005 10:33:12 +0900	[thread overview]
Message-ID: <42D46F58.4070900@jp.fujitsu.com> (raw)
In-Reply-To: <20050712195120.GE26607@austin.ibm.com>

Linas Vepstas wrote:
> Thus, one wouldn't want to perform an iochk_read() in this way unless
> one was already pretty sure that an error had already occured ... 

If another kind of I/O error detecting system finds a error before
performing iochk_read(), it can prevents coming iochk_read() from
spending such crazy cycles in have_error() by marking cookie->error.

 >> int iochk_read(iocookie *cookie)
 >>  {
 >> +	if (cookie->error || have_error(cookie->dev))

Isn't it enough?

And as Ben said, it seems that ppc64 can have its own special iochk_*,
unless calling pci_read_config_word() ;-)

Thanks,
H.Seto


  parent reply	other threads:[~2005-07-13  1:33 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-06  4:53 [PATCH 2.6.13-rc1 01/10] IOCHK interface for I/O error handling/detecting Hidetoshi Seto
2005-07-06  4:53 ` Hidetoshi Seto
2005-07-06  4:58 ` [PATCH 2.6.13-rc1 02/10] " Hidetoshi Seto
2005-07-06  5:00   ` Hidetoshi Seto
2005-07-06  5:04 ` [PATCH 2.6.13-rc1 03/10] " Hidetoshi Seto
2005-07-06  5:04   ` Hidetoshi Seto
2005-07-12 19:51   ` Linas Vepstas
2005-07-12 19:51     ` Linas Vepstas
2005-07-13  0:18     ` [PATCH 2.6.13-rc1 03/10] IOCHK interface for I/O error Benjamin Herrenschmidt
2005-07-13  0:18       ` [PATCH 2.6.13-rc1 03/10] IOCHK interface for I/O error handling/detecting Benjamin Herrenschmidt
2005-07-13 22:42       ` Linas Vepstas
2005-07-13 22:42         ` Linas Vepstas
2005-07-13  1:33     ` Hidetoshi Seto [this message]
2005-07-13  1:33       ` Hidetoshi Seto
2005-07-06  5:07 ` [PATCH 2.6.13-rc1 04/10] " Hidetoshi Seto
2005-07-06  5:07   ` Hidetoshi Seto
2005-07-06  5:11 ` [PATCH 2.6.13-rc1 05/10] " Hidetoshi Seto
2005-07-06  5:11   ` Hidetoshi Seto
2005-07-18 19:21   ` Grant Grundler
2005-07-18 19:21     ` Grant Grundler
2005-07-06  5:14 ` [PATCH 2.6.13-rc1 06/10] " Hidetoshi Seto
2005-07-06  5:14   ` Hidetoshi Seto
2005-07-06  5:17 ` [PATCH 2.6.13-rc1 07/10] " Hidetoshi Seto
2005-07-06  5:17   ` Hidetoshi Seto
2005-07-08  4:37   ` david mosberger
2005-07-08  4:37     ` david mosberger
2005-07-08  5:44     ` Hidetoshi Seto
2005-07-08  5:44       ` Hidetoshi Seto
2005-07-08 19:05   ` Luck, Tony
2005-07-08 19:23   ` david mosberger
2005-07-08 20:17   ` Luck, Tony
2005-07-11 17:51   ` Jesse Barnes
2005-07-11 18:21   ` Luck, Tony
2005-07-11 19:21   ` david mosberger
2005-07-12 21:14   ` Linas Vepstas
2005-07-12 21:14     ` Linas Vepstas
2005-07-13  1:59     ` Hidetoshi Seto
2005-07-13  2:00       ` Hidetoshi Seto
2005-07-06  5:18 ` [PATCH 2.6.13-rc1 08/10] " Hidetoshi Seto
2005-07-06  5:18   ` Hidetoshi Seto
2005-07-12 22:22   ` Linas Vepstas
2005-07-12 22:22     ` Linas Vepstas
2005-07-13  1:36     ` Hidetoshi Seto
2005-07-13  1:36       ` Hidetoshi Seto
2005-07-06  5:20 ` [PATCH 2.6.13-rc1 09/10] " Hidetoshi Seto
2005-07-06  5:20   ` Hidetoshi Seto
2005-07-06  5:21 ` [PATCH 2.6.13-rc1 10/10] " Hidetoshi Seto
2005-07-06  5:21   ` Hidetoshi Seto
2005-07-06  6:26 ` [PATCH 2.6.13-rc1 01/10] IOCHK interface for I/O error 
2005-07-06  6:26   ` [PATCH 2.6.13-rc1 01/10] IOCHK interface for I/O error handling/detecting YOSHIFUJI Hideaki / 吉藤英明
2005-07-06 10:15   ` Hidetoshi Seto
2005-07-06 10:15     ` Hidetoshi Seto
2005-07-07 18:41 ` Greg KH
2005-07-07 18:41   ` Greg KH
2005-07-07 22:27   ` [PATCH 2.6.13-rc1 01/10] IOCHK interface for I/O error Benjamin Herrenschmidt
2005-07-07 22:27     ` [PATCH 2.6.13-rc1 01/10] IOCHK interface for I/O error handling/detecting Benjamin Herrenschmidt
2005-07-08 12:22     ` Hidetoshi Seto
2005-07-08 12:22       ` Hidetoshi Seto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42D46F58.4070900@jp.fujitsu.com \
    --to=seto.hidetoshi@jp.fujitsu.com \
    --cc=benh@kernel.crashing.org \
    --cc=linas@austin.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=tlnguyen@snoqualmie.dp.intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.