* [NETFILTER 3/5]: Wait until all references to ip_conntrack_untracked are dropped on unload
@ 2005-07-22 7:35 Patrick McHardy
2005-07-22 19:51 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2005-07-22 7:35 UTC (permalink / raw)
To: David S. Miller; +Cc: Netfilter Development Mailinglist, stable
[-- Attachment #1: 03.diff --]
[-- Type: text/x-patch, Size: 1111 bytes --]
[NETFILTER]: Wait until all references to ip_conntrack_untracked are dropped on unload
Fixes a crash when unloading ip_conntrack.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit dd51c6e4ab8df9819d686b0a88a6d7ec8b3d2b28
tree 1b8d3369a5ffff34a263c2c4fbb206d948178a30
parent ca30527af14847bab487c91df56f99df3c7ad1b2
author Patrick McHardy <kaber@trash.net> Fri, 22 Jul 2005 09:23:28 +0200
committer Patrick McHardy <kaber@trash.net> Fri, 22 Jul 2005 09:23:28 +0200
net/ipv4/netfilter/ip_conntrack_core.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/netfilter/ip_conntrack_core.c b/net/ipv4/netfilter/ip_conntrack_core.c
--- a/net/ipv4/netfilter/ip_conntrack_core.c
+++ b/net/ipv4/netfilter/ip_conntrack_core.c
@@ -1111,6 +1111,9 @@ void ip_conntrack_cleanup(void)
schedule();
goto i_see_dead_people;
}
+ /* wait until all references to ip_conntrack_untracked are dropped */
+ while (atomic_read(&ip_conntrack_untracked.ct_general.use) > 1)
+ schedule();
kmem_cache_destroy(ip_conntrack_cachep);
kmem_cache_destroy(ip_conntrack_expect_cachep);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [NETFILTER 3/5]: Wait until all references to ip_conntrack_untracked are dropped on unload
2005-07-22 7:35 [NETFILTER 3/5]: Wait until all references to ip_conntrack_untracked are dropped on unload Patrick McHardy
@ 2005-07-22 19:51 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-07-22 19:51 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel, stable
From: Patrick McHardy <kaber@trash.net>
Date: Fri, 22 Jul 2005 09:35:51 +0200
> [NETFILTER]: Wait until all references to ip_conntrack_untracked are dropped on unload
>
> Fixes a crash when unloading ip_conntrack.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-22 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-22 7:35 [NETFILTER 3/5]: Wait until all references to ip_conntrack_untracked are dropped on unload Patrick McHardy
2005-07-22 19:51 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.